Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: T-C views components events migration #8692

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Conversation

tommasini
Copy link
Contributor

Description

View component migration from T-C initial letters

Implemented trackOnboarding from segments drafts!

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform labels Feb 23, 2024
@tommasini tommasini requested a review from a team as a code owner February 23, 2024 00:32
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 23, 2024
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1188c595-b963-47d4-b8bd-2ba68dd924df
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 32.07547% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 41.46%. Comparing base (291bc71) to head (0af3c78).
Report is 10 commits behind head on main.

Files Patch % Lines
app/components/Views/Quiz/SRPQuiz/SRPQuiz.tsx 0.00% 11 Missing ⚠️
app/components/Views/DetectedTokens/index.tsx 0.00% 4 Missing ⚠️
app/components/Views/ConnectQRHardware/index.tsx 0.00% 3 Missing ⚠️
...mponents/Views/EditAccountName/EditAccountName.tsx 70.00% 3 Missing ⚠️
app/components/Views/LedgerConnect/index.tsx 0.00% 3 Missing ⚠️
...nts/Views/ConnectHardware/SelectHardware/index.tsx 0.00% 2 Missing ⚠️
app/components/Views/LedgerAccountInfo/index.tsx 0.00% 2 Missing ⚠️
...ents/Views/ImportFromSecretRecoveryPhrase/index.js 0.00% 1 Missing ⚠️
app/components/Views/Login/index.js 0.00% 1 Missing ⚠️
app/components/Views/ManualBackupStep1/index.js 0.00% 1 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8692      +/-   ##
==========================================
- Coverage   41.53%   41.46%   -0.07%     
==========================================
  Files        1260     1263       +3     
  Lines       30615    30604      -11     
  Branches     3005     3008       +3     
==========================================
- Hits        12716    12691      -25     
- Misses      17145    17159      +14     
  Partials      754      754              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link

sonarcloud bot commented Feb 23, 2024

@tommasini tommasini merged commit 667d8c8 into main Feb 23, 2024
28 checks passed
@tommasini tommasini deleted the feat/batch_1129_segment_13 branch February 23, 2024 15:26
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 23, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2024
@metamaskbot metamaskbot added release-7.18.0 Issue or pull request that will be included in release 7.18.0 in-progress labels Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
in-progress release-7.18.0 Issue or pull request that will be included in release 7.18.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants