-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Snaps new architecture mobile integration #8700
Conversation
…/metamask-mobile into feat/bump-mobile-snaps-packages
…/metamask-mobile into feat/bump-mobile-snaps-packages
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/permission-controller@4.1.2, npm/@types/readable-stream@4.0.9 |
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8700 +/- ##
==========================================
+ Coverage 41.54% 41.60% +0.06%
==========================================
Files 1268 1263 -5
Lines 30664 30625 -39
Branches 3011 3011
==========================================
+ Hits 12738 12741 +3
+ Misses 17172 17130 -42
Partials 754 754 ☔ View full report in Codecov by Sentry. |
…/metamask-mobile into feat/snaps-integration-refactor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All comments addressed.
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All comments addressed on the following PR
Description
This PR adds a refactored Snaps Webview approach and embedded execution environment to allow mobile app consume the new mobile snaps architecture.
Related issues
Fixes: N/A
After Screenshot
Screen.Recording.2024-02-23.at.14.56.20.mov
Manual testing steps
Pre-merge author checklist
Pre-merge reviewer checklist
CI Related Section: DO NOT EDIT
Flag used by Bitrise to either run or skip E2E smoke tests