-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: notifications library - [2 of 10] #8701
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@react-native-async-storage/async-storage@1.17.10, npm/react-native-push-notification@3.1.3 |
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
…ile into feat/notifications
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8701 +/- ##
==========================================
- Coverage 43.67% 43.61% -0.07%
==========================================
Files 1271 1275 +4
Lines 30921 30975 +54
Branches 3092 3098 +6
==========================================
+ Hits 13506 13509 +3
- Misses 16636 16687 +51
Partials 779 779 ☔ View full report in Codecov by Sentry. |
@sethkfman thanks for the heads up. Based on |
…ile into feat/notifications
Quality Gate passedIssues Measures |
Description
Within the scope of Notifications Project, this PR replaces libraries and approaches on how MetaMask handles notifications to our users. The adoption of this approach will pave the way for MM make usage of push notifications (back/foregrounds).
REMINDER: Although this PR can be reviewed separately, triggering a NEW BUILD should be done together with UI changes PR so the user can have full control about push notifications.
Related issues
Fixes: Jira Ticket
Manual testing steps
Screenshots/Recordings
After
Screen.Recording.2024-03-06.at.11.36.42.mov
Pre-merge author checklist
Pre-merge reviewer checklist