Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: c-a views components events migration to segment #8711

Merged
merged 6 commits into from
Feb 26, 2024

Conversation

tommasini
Copy link
Contributor

Description

C-A views component events migration to segment

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform labels Feb 23, 2024
@tommasini tommasini requested a review from a team as a code owner February 23, 2024 23:44
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some issues to fix:

  • trackDappVisitedEvent should not be updated here (and it should be moved instead of added)
  • no need for empty properties object in trackEvent calls
  • missing one InteractionManager removal

app/components/Views/AccountConnect/AccountConnect.tsx Outdated Show resolved Hide resolved
app/components/Views/AccountActions/AccountActions.tsx Outdated Show resolved Hide resolved
app/components/Views/AccountConnect/AccountConnect.tsx Outdated Show resolved Hide resolved
app/components/Views/AccountConnect/AccountConnect.tsx Outdated Show resolved Hide resolved
app/components/Views/Asset/index.js Outdated Show resolved Hide resolved
app/components/Views/Browser/index.js Show resolved Hide resolved
app/components/Views/BrowserTab/index.js Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 18.64407% with 48 lines in your changes are missing coverage. Please review.

Project coverage is 41.47%. Comparing base (baed762) to head (a92ef18).

Files Patch % Lines
app/components/Views/BrowserTab/index.js 0.00% 13 Missing ⚠️
...ts/Views/AccountPermissions/AccountPermissions.tsx 0.00% 7 Missing ⚠️
...components/Views/AccountConnect/AccountConnect.tsx 0.00% 6 Missing ⚠️
...ents/Views/AddAccountActions/AddAccountActions.tsx 0.00% 4 Missing ⚠️
...ountPermissionsRevoke/AccountPermissionsRevoke.tsx 0.00% 3 Missing ⚠️
app/components/Views/Browser/index.js 0.00% 3 Missing ⚠️
...rmissionsConnected/AccountPermissionsConnected.tsx 0.00% 2 Missing ⚠️
...mponents/Views/AccountSelector/AccountSelector.tsx 0.00% 2 Missing ⚠️
app/components/Views/ActivityView/index.js 0.00% 2 Missing ⚠️
app/components/Views/AssetDetails/index.tsx 0.00% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8711   +/-   ##
=======================================
  Coverage   41.46%   41.47%           
=======================================
  Files        1263     1264    +1     
  Lines       30610    30622   +12     
  Branches     3008     3008           
=======================================
+ Hits        12693    12700    +7     
- Misses      17164    17169    +5     
  Partials      753      753           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

NicolasMassart
NicolasMassart previously approved these changes Feb 26, 2024
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link

sonarcloud bot commented Feb 26, 2024

@NicolasMassart NicolasMassart merged commit 2809783 into main Feb 26, 2024
28 checks passed
@NicolasMassart NicolasMassart deleted the feat/batch_1129_segment_17 branch February 26, 2024 16:37
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 26, 2024
@metamaskbot metamaskbot added the release-7.18.0 Issue or pull request that will be included in release 7.18.0 label Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.18.0 Issue or pull request that will be included in release 7.18.0 team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants