-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Onboarding add custom default ETH Mainnet #8723
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Fix merge conflicts
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8723 +/- ##
=======================================
Coverage 43.23% 43.23%
=======================================
Files 1271 1271
Lines 30905 30905
Branches 3088 3088
=======================================
Hits 13361 13361
Misses 16769 16769
Partials 775 775 ☔ View full report in Codecov by Sentry. |
app/components/Views/Settings/NetworksSettings/NetworkSettings/index.js
Outdated
Show resolved
Hide resolved
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7232eb05-77eb-4bc1-84ab-733f93f651bd |
Bitrise✅✅✅ Commit hash: 521ad1d Note
|
Bitrise✅✅✅ Commit hash: 5ce5cc7 Note
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good 👍
Description
New test for adding a custom default ETH Mainnet during Onboarding after MMM has been installed on device.
Added this test as part of the Regression tests.
Related issues
Fixes: https://github.com/MetaMask/mobile-planning/issues/1455
Manual testing steps
On local machine run on this branch...
Android:
yarn test:e2e:android:debug:single ./e2e/specs/onboarding/add-custom-eth-mainnet.spec.js
iOS:
yarn test:e2e:ios:debug:single ./e2e/specs/onboarding/add-custom-eth-mainnet.spec.js
On bitrise run
pr_regression_e2e_pipeline
on this branch.Above steps should pass.
Screenshots/Recordings
Before
After
Regression tests: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/27207577-3107-4fdb-b0b7-56561831c263
Smoke tests: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6d64d3b0-8537-4c24-8b98-a832bfdd4211
Screen.Recording.2024-02-26.at.11.48.29.AM.mov
Pre-merge author checklist
Pre-merge reviewer checklist