Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(8718): modify nearby devices permission wording + related enum #8730

Closed
wants to merge 1 commit into from

Conversation

Akaryatrh
Copy link
Contributor

Description

Modify wording for ledger nearby devices permissions access as requested here. Also modified related enum.

Related issues

Fixes: #8718 (comment)

Manual testing steps

  1. Go to Settings>Apps>MetaMask and disable Nearby Devices
  2. Open MetaMask
  3. Attempt to send testnet eth
  4. After selecting a destination and an amount tap Confirm with Ledger
  5. When prompted for permission select Don't allow
  6. Note error

Screenshots/Recordings

TBD as I'm not able to access the error on my specific device.

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarcloud bot commented Feb 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.46%. Comparing base (6841a91) to head (7e9f43d).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8730      +/-   ##
==========================================
- Coverage   41.47%   41.46%   -0.01%     
==========================================
  Files        1263     1264       +1     
  Lines       30610    30622      +12     
  Branches     3008     3008              
==========================================
+ Hits        12694    12697       +3     
- Misses      17162    17172      +10     
+ Partials      754      753       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Akaryatrh
Copy link
Contributor Author

Closed in favor of #8745

@Akaryatrh Akaryatrh closed this Feb 27, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants