-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix hex to BN conversion #8734
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bca0d0cf-c909-4f3d-bb9a-d78ee8f9aee1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8734 +/- ##
==========================================
+ Coverage 41.46% 41.53% +0.07%
==========================================
Files 1264 1268 +4
Lines 30622 30663 +41
Branches 3008 3011 +3
==========================================
+ Hits 12697 12737 +40
Misses 17172 17172
- Partials 753 754 +1 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
Description
conversion from hex to BN doesn't work for very large numbers, because the convertHexToDecimal function uses parseInt to convert from hex to decimal, but for numbers greater than 54 digits this may send an incorrect result.
the fix was to use
toHexBN
functionRelated issues
Fixes: #8703
Manual testing steps
2.Go to the received/sen activity
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist