Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: segment migration update remaining files and remove legacy analytics #8748

Merged
merged 4 commits into from
Feb 28, 2024

Conversation

NicolasMassart
Copy link
Contributor

@NicolasMassart NicolasMassart commented Feb 27, 2024

Description

Segment migration:

  • update remaining files that missed changes
  • remove legacy analytics
  • fixed some typing issues
  • removed obviously unused events
  • fix unit test

Related issues

Fixes https://github.com/MetaMask/mobile-planning/issues/1129

Important

I added a TODO related a a dependency issue outside of the scope of this PR.
issue created for it: #8756

Manual testing steps

None, use e2e

Screenshots/Recordings

Before

NA

After

NA

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NicolasMassart NicolasMassart added No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform needs-smoke-e2e labels Feb 27, 2024
@NicolasMassart NicolasMassart self-assigned this Feb 27, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 23.07692% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 41.60%. Comparing base (70eff9c) to head (df1e47f).

Files Patch % Lines
app/components/Nav/App/index.js 0.00% 3 Missing ⚠️
app/core/SecureKeychain.js 40.00% 3 Missing ⚠️
app/components/Views/Quiz/SRPQuiz/SRPQuiz.tsx 0.00% 2 Missing ⚠️
app/util/termsOfUse/termsOfUse.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8748      +/-   ##
==========================================
+ Coverage   41.42%   41.60%   +0.18%     
==========================================
  Files        1270     1268       -2     
  Lines       30832    30675     -157     
  Branches     3046     3046              
==========================================
- Hits        12772    12763       -9     
+ Misses      17296    17148     -148     
  Partials      764      764              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NicolasMassart NicolasMassart marked this pull request as ready for review February 27, 2024 18:54
@NicolasMassart NicolasMassart requested a review from a team as a code owner February 27, 2024 18:54
@NicolasMassart NicolasMassart added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 27, 2024
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6aab77f5-fa03-4355-9c00-7bf08e1ad586
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/391d58aa-369b-4689-b777-019681ff01b9
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@NicolasMassart NicolasMassart added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 28, 2024
Copy link

sonarcloud bot commented Feb 28, 2024

Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's sync with the team how to remove the circular dependency

@NicolasMassart NicolasMassart merged commit c38445c into main Feb 28, 2024
34 checks passed
@NicolasMassart NicolasMassart deleted the feat/batch_1129_segment_17 branch February 28, 2024 13:34
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2024
@github-actions github-actions bot removed in-progress needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Feb 28, 2024
@metamaskbot metamaskbot added the release-7.18.0 Issue or pull request that will be included in release 7.18.0 label Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-smoke-e2e No QA Needed Apply this label when your PR does not need any QA effort. release-7.18.0 Issue or pull request that will be included in release 7.18.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants