-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
patch (webview upgrade): Add delay for android browser permission dialog #8749
patch (webview upgrade): Add delay for android browser permission dialog #8749
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise✅✅✅ Commit hash: e249ca0 Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏🏼
05fb266
to
e249ca0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## upgrade/react-native-webview #8749 +/- ##
=============================================================
Coverage 43.27% 43.27%
=============================================================
Files 1271 1271
Lines 30914 30914
Branches 3091 3091
=============================================================
Hits 13377 13377
Misses 16764 16764
Partials 773 773 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. See linked issue for test recordings.
Description
This change is part of the file react-native-webview+11.13.0.patch, a collection of patches that we need to apply on top of react-native-webview.
Webview changes can be reviewed here:
MetaMask/react-native-webview-mm#10
Original Pull Request:
#6745
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist