Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch (webview upgrade): Add delay for android browser permission dialog #8749

Conversation

jpcloureiro
Copy link
Contributor

@jpcloureiro jpcloureiro commented Feb 27, 2024

Description

This change is part of the file react-native-webview+11.13.0.patch, a collection of patches that we need to apply on top of react-native-webview.

Webview changes can be reviewed here:
MetaMask/react-native-webview-mm#10

Original Pull Request:
#6745

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpcloureiro jpcloureiro marked this pull request as ready for review March 7, 2024 14:21
@jpcloureiro jpcloureiro requested a review from a team as a code owner March 7, 2024 14:21
@jpcloureiro jpcloureiro added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 7, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Mar 7, 2024
@github-actions github-actions bot added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 7, 2024
Copy link
Contributor

github-actions bot commented Mar 7, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e249ca0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1be7c519-dcbb-41e8-bbd1-526f2a21319b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@jpcloureiro jpcloureiro self-assigned this Mar 7, 2024
Copy link
Contributor

@MarioAslau MarioAslau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏼

@jpcloureiro jpcloureiro requested a review from a team as a code owner March 13, 2024 16:42
@jpcloureiro jpcloureiro force-pushed the webview-upgrade/delay-android-prompt branch from 05fb266 to e249ca0 Compare March 13, 2024 16:58
@jpcloureiro jpcloureiro removed the request for review from a team March 13, 2024 16:59
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.27%. Comparing base (f2bcf80) to head (5983425).

Additional details and impacted files
@@                      Coverage Diff                      @@
##           upgrade/react-native-webview    #8749   +/-   ##
=============================================================
  Coverage                         43.27%   43.27%           
=============================================================
  Files                              1271     1271           
  Lines                             30914    30914           
  Branches                           3091     3091           
=============================================================
  Hits                              13377    13377           
  Misses                            16764    16764           
  Partials                            773      773           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Mar 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jpcloureiro jpcloureiro added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Mar 15, 2024
@chrisleewilcox chrisleewilcox added QA in Progress QA has started on the feature. QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. QA in Progress QA has started on the feature. labels Mar 25, 2024
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. See linked issue for test recordings.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template QA Passed A successful QA run through has been done RNWebView Run Smoke E2E Triggers smoke e2e on Bitrise
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants