-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove gap from maxHeight calculation in bottomsheet #8755
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
I think the reference to that deleted constant must be deleted as well in const maxSheetHeight = isFullscreen
? screenHeight - screenTopPadding
: screenHeight - screenTopPadding - DEFAULT_BOTTOMSHEETDIALOG_MARGINTOP; |
…to morph/bs-margintop
Somehow the change to the main file was not committed. Updated PR |
2619bf3
Quality Gate passedIssues Measures |
Description
Related issues
Fixes: #8754
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist