feat: Remove gap from maxHeight calculation in bottomsheet

[brianacnguyen]

Description

• This PR removes the marginTop calculation from the maxHeight calculation in BottomSheet

Related issues

Fixes: #8754

Manual testing steps

1. Go to any bottomsheet

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[wachunei]

I think the reference to that deleted constant must be deleted as well in app/component-library/components/BottomSheets/BottomSheet/foundation/BottomSheetDialog/BottomSheetDialog.tsx

const maxSheetHeight = isFullscreen
      ? screenHeight - screenTopPadding
      : screenHeight - screenTopPadding - DEFAULT_BOTTOMSHEETDIALOG_MARGINTOP;

[wachunei]

Just to confirm, the reference to the deleted variable must be deleted otherwise the app crashes:

[brianacnguyen]

I think the reference to that deleted constant must be deleted as well in app/component-library/components/BottomSheets/BottomSheet/foundation/BottomSheetDialog/BottomSheetDialog.tsx

const maxSheetHeight = isFullscreen
      ? screenHeight - screenTopPadding
      : screenHeight - screenTopPadding - DEFAULT_BOTTOMSHEETDIALOG_MARGINTOP;

Somehow the change to the main file was not committed. Updated PR

[sonarcloud]

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud