-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cherry-pick #8744 #8757
chore: cherry-pick #8744 #8757
Conversation
## **Description** We are exposing our network API keys in the network verification details. Exposing API keys should be avoided due to their significant security risks. To reproduce: Go to networks view Proceed to add any infura supported network from the popular network list. Polygon is a good example. Notice in the network approval modal the Infura API key is exposed in the Network URL field. ## **Related issues** Fixes: [#1574](MetaMask/mobile-planning#1574) ## **Manual testing steps** 1. Go to the add network page 2. Choose polygon and click on add 3. A modal will be displayed, scroll down to see the RPC Url 4. Infura url should not display the api key ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** ![before](https://github.com/MetaMask/metamask-mobile/assets/26223211/1faf9b53-9a2c-4a73-96c4-8273ac899b59) ### **After** <img width="439" alt="Screenshot 2024-02-27 at 13 18 42" src="https://github.com/MetaMask/metamask-mobile/assets/26223211/4987d957-161f-47f0-81e2-76b8b28e11f8"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [x] I've linked related issues - [x] I've included manual testing steps - [x] I've included screenshots/recordings if applicable - [x] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [x] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fb328088-a18c-468a-8bf9-1e37cc3f758e |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a44ed1d3-fe3a-460b-8410-2530bcb9a056 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No release label on PR. Adding release label release-7.17.0 on PR, as PR was cherry-picked in branch 7.17.0. |
This PR cherry-picks #8744