Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick #8708 #8760

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Feb 28, 2024

Cherry-pick fix for #8708 on version 7.17.0.

@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner February 28, 2024 01:06
@matthewwalsh0 matthewwalsh0 added team-confirmations-system DEPRECATED: please use "team-confirmations" label instead Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 28, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Feb 28, 2024
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/89aabe9b-f13c-4380-b716-5d7ce6160a71
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blackdevelopa blackdevelopa force-pushed the fix/8708-custom-gas-ignored-cherry-pick branch from e1f75a3 to f6a2ccf Compare February 29, 2024 16:16
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarcloud bot commented Feb 29, 2024

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 47.36842% with 10 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release/7.17.0@bf433de). Click here to learn what that means.

Files Patch % Lines
...ents/Views/confirmations/SendFlow/Confirm/index.js 47.36% 10 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             release/7.17.0    #8760   +/-   ##
=================================================
  Coverage                  ?   41.16%           
=================================================
  Files                     ?     1249           
  Lines                     ?    30443           
  Branches                  ?     2975           
=================================================
  Hits                      ?    12532           
  Misses                    ?    17162           
  Partials                  ?      749           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sethkfman sethkfman merged commit 5e2d228 into release/7.17.0 Feb 29, 2024
25 checks passed
@sethkfman sethkfman deleted the fix/8708-custom-gas-ignored-cherry-pick branch February 29, 2024 16:35
@github-actions github-actions bot locked and limited conversation to collaborators Feb 29, 2024
@metamaskbot metamaskbot added the release-7.17.0 Issue or pull request that will be included in release 7.17.0 label Feb 29, 2024
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-7.17.0 on PR, as PR was cherry-picked in branch 7.17.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-7.17.0 Issue or pull request that will be included in release 7.17.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations-system DEPRECATED: please use "team-confirmations" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants