Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PPOM version update to 1.4.2 #8763

Merged
merged 1 commit into from
Feb 28, 2024
Merged

fix: PPOM version update to 1.4.2 #8763

merged 1 commit into from
Feb 28, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Feb 28, 2024

Description

Update PPOM to latest version 1.4.2

Related issues

Fixes: MetaMask/MetaMask-planning#2149

Manual testing steps

  1. Go to test dapp
  2. Submit couple of benign / malicious transactions
  3. Ensure that validation is done as expected

Screenshots/Recordings

NA

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux-PR PR from the confirmations team Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 28, 2024
@jpuri jpuri requested a review from a team as a code owner February 28, 2024 06:16
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri changed the title PPOM version update to 1.4.2 fix: PPOM version update to 1.4.2 Feb 28, 2024
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/18ff8867-6469-4c0e-9c1a-df6c1f411147
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link

sonarcloud bot commented Feb 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.42%. Comparing base (70eff9c) to head (98fea8d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8763   +/-   ##
=======================================
  Coverage   41.42%   41.42%           
=======================================
  Files        1270     1270           
  Lines       30832    30832           
  Branches     3046     3046           
=======================================
  Hits        12772    12772           
  Misses      17296    17296           
  Partials      764      764           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpuri jpuri merged commit 0217919 into main Feb 28, 2024
38 of 39 checks passed
@jpuri jpuri deleted the ppom_update_1.4.2 branch February 28, 2024 15:11
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 28, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2024
@metamaskbot metamaskbot added the release-7.18.0 Issue or pull request that will be included in release 7.18.0 label Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.18.0 Issue or pull request that will be included in release 7.18.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations-secure-ux-PR PR from the confirmations team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants