-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cherry-pick (#8727) #8766
fix: cherry-pick (#8727) #8766
Conversation
<!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Migrating from a previous version to v7.17.0 should enable Blockaid by default in the same way it's done with 7.17.0 fresh installs. Fixes: #8669 1. Install v7.16 2. Update to v7.17 3. Check settings --> see Blockaid is enabled <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> <!-- [screenshots/recordings] --> <!-- [screenshots/recordings] --> - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [x] I've linked related issues - [x] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I’ve properly set the pull request status: - [x] In case it's not yet "ready for review", I've set it to "draft". - [x] In case it's "ready for review", I've changed it from "draft" to "non-draft". - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/7.17.0 #8766 +/- ##
=================================================
Coverage ? 41.14%
=================================================
Files ? 1249
Lines ? 30440
Branches ? 2975
=================================================
Hits ? 12524
Misses ? 17167
Partials ? 749 ☔ View full report in Codecov by Sentry. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fd915f19-d28f-4f95-819b-789e08a1b1f4 |
Quality Gate passedIssues Measures |
🟢 from QA looks good:
blockaid-enabled-default-migration.mp4
blockaid-enabled-default-fresh-install.mp4 |
No release label on PR. Adding release label release-7.17.0 on PR, as PR was cherry-picked in branch 7.17.0. |
Cherry-pick fix for #8727 on version 7.17.0.