Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: state logs in the exported file with app version and build number #8768

Merged
merged 6 commits into from
Mar 4, 2024
Merged

feat: state logs in the exported file with app version and build number #8768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
25ca368
state logs with app version and build number
tommasini Feb 28, 2024
8a0656a
update tests and change name of logs variable
tommasini Mar 1, 2024
a388be9
update logs test case
tommasini Mar 1, 2024
1a387da
Update app/util/logs/index.test.ts
tommasini Mar 1, 2024
b8cec18
Merge branch 'main' into feat/changelogs-with-app-version
tommasini Mar 1, 2024
d7fd8bd
Merge branch 'main' into feat/changelogs-with-app-version
tommasini Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions app/components/Views/Settings/AdvancedSettings/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,12 +266,18 @@ class AdvancedSettings extends PureComponent {
// A not so great way to copy objects by value

try {
const data = generateStateLogs(fullState);
const stateLogsWithReleaseDetails = generateStateLogs({
...fullState,
appVersion,
buildNumber,
});

let url = `data:text/plain;base64,${new Buffer(data).toString('base64')}`;
let url = `data:text/plain;base64,${new Buffer(
stateLogsWithReleaseDetails,
).toString('base64')}`;
// // Android accepts attachements as BASE64
if (Device.isIos()) {
await RNFS.writeFile(path, data, 'utf8');
await RNFS.writeFile(path, stateLogsWithReleaseDetails, 'utf8');
url = path;
}

Expand Down
27 changes: 27 additions & 0 deletions app/util/logs/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,39 @@ describe('logs :: generateStateLogs', () => {
},
};
const logs = generateStateLogs(mockStateInput);

expect(logs.includes('NftController')).toBe(false);
expect(logs.includes('TokensController')).toBe(false);
expect(logs.includes('AssetsContractController')).toBe(false);
expect(logs.includes('TokenDetectionController')).toBe(false);
expect(logs.includes('NftDetectionController')).toBe(false);
expect(logs.includes('PhishingController')).toBe(false);
expect(logs.includes("vault: 'vault mock'")).toBe(false);
});

it('generates extra logs if values added to the state object parameter', () => {
const mockStateInput = {
appVersion: '1',
buildNumber: '123',
engine: {
backgroundState: {
...initialBackgroundState,
KeyringController: {
vault: 'vault mock',
},
},
},
};
const logs = generateStateLogs(mockStateInput);
tommasini marked this conversation as resolved.
Show resolved Hide resolved

expect(logs.includes('NftController')).toBe(false);
expect(logs.includes('TokensController')).toBe(false);
expect(logs.includes('AssetsContractController')).toBe(false);
expect(logs.includes('TokenDetectionController')).toBe(false);
expect(logs.includes('NftDetectionController')).toBe(false);
expect(logs.includes('PhishingController')).toBe(false);
expect(logs.includes("vault: 'vault mock'")).toBe(false);
expect(logs.includes('appVersion')).toBe(true);
expect(logs.includes('buildNumber')).toBe(true);
});
});
Loading