-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: normalize transaction parameters before PPOM validation #8774
Conversation
Quality Gate passedIssues Measures |
Bitrise🔄🔄🔄 Commit hash: 49e5309 Note
|
This looks good from QA:
I've triggered a Bitrise e2e build here: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/961e97dd-afd4-4ed1-962f-6487f418d0f0 odd-hex-data-mobile.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work, @matthewwalsh0!
Description
Update the
TransactionController
to pad thedata
property to an even length to ensure the client UIs receive a consistentdata
value.Normalize transaction parameters before validating with the PPOM to ensure the
data
can be parsed correctly, and all parameters are in a consistent format.See the core branch diff for a clearer view of the patch changes.
Related issues
Fixes: #2152 #2153
Manual testing steps
data
.Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist