-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Assets controllers update to version 10 #8778
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8778 +/- ##
=======================================
Coverage 41.63% 41.63%
=======================================
Files 1270 1270
Lines 30887 30887
Branches 3083 3083
=======================================
+ Hits 12859 12860 +1
+ Misses 17250 17249 -1
Partials 778 778 ☔ View full report in Codecov by Sentry. |
Bitrise🔄🔄🔄 Commit hash: 8dc40f0 Note
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/assets-controllers@9.2.0, npm/zxcvbn@4.4.2 |
Bitrise❌❌❌ Commit hash: f61980e Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Bitrise✅✅✅ Commit hash: eb5b7bd Note
|
Quality Gate passedIssues Measures |
Description
Update assets controllers to version 10
Added script to make easier update the next versions of assets-controllers
Core branch with changes:
patch/mobile-assets-controllers-v10
: https://github.com/MetaMask/core/tree/patch/mobile-assets-controllers-v10Still missing recordings of exploratory testing
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Token exploration: https://recordit.co/jiLNME568H
NFT exploration: https://recordit.co/QtOD9Gw1Va
Add token via dapp: https://recordit.co/t22cGKhdmG
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist