-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove minimatch
resolution
#8807
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8807 +/- ##
=======================================
Coverage 41.61% 41.61%
=======================================
Files 1269 1269
Lines 30869 30869
Branches 3086 3086
=======================================
Hits 12847 12847
Misses 17245 17245
Partials 777 777 ☔ View full report in Codecov by Sentry. |
2d00166
to
6c452c5
Compare
Bitrise✅✅✅ Commit hash: 6c452c5 Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6c452c5
to
0f7ab5d
Compare
Rebased to resolve conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This `minimatch` resolution was added in #5142 to address a security advisory. It is no longer needed, that advisory is not present after removing the resolution. This resolution was unsafe because it was forcing the use of incompatible versions of the package.
0f7ab5d
to
95a599c
Compare
Rebased to resolve conflicts |
Quality Gate passedIssues Measures |
Description
This
minimatch
resolution was added in #5142 to address a security advisory. It is no longer needed, that advisory is not present after removing the resolution.This resolution was unsafe because it was forcing the use of incompatible versions of the package.
Related issues
N/A
Manual testing steps
N/A
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist