-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove y18n
resolution
#8817
Conversation
Bitrise✅✅✅ Commit hash: 32c7448 Note
|
e164db2
to
272a4e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
272a4e5
to
82de86e
Compare
Rebased to resolve conflicts |
82de86e
to
8a9d174
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8817 +/- ##
=======================================
Coverage 41.61% 41.61%
=======================================
Files 1269 1269
Lines 30869 30869
Branches 3086 3086
=======================================
Hits 12847 12847
Misses 17245 17245
Partials 777 777 ☔ View full report in Codecov by Sentry. |
8a9d174
to
b7edf03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This resolution was added in #2445 to update the package to resolve a security advisory. The resolution wasn't really needed for the update; effectively the resolution has only resulted in the package being downgraded to v3.
b7edf03
to
8d7fc36
Compare
Rebased to resolve conflicts again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Quality Gate passedIssues Measures |
Description
This resolution was added in #2445 to update the package to resolve a security advisory. The resolution wasn't really needed for the update; effectively the resolution has only resulted in the package being downgraded to v3.
Related issues
N/A
Manual testing steps
N/A
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist