-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: preinstalled mobile snaps - [1 of 10] #8827
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is new author?A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package. Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
Bitrise✅✅✅ Commit hash: 8c30f04 Note
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8827 +/- ##
==========================================
+ Coverage 45.80% 45.97% +0.17%
==========================================
Files 1317 1329 +12
Lines 32329 32444 +115
Branches 3369 3400 +31
==========================================
+ Hits 14807 14915 +108
Misses 16633 16633
- Partials 889 896 +7 ☔ View full report in Codecov by Sentry. |
Bitrise❌❌❌ Commit hash: 9eff63a Note
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Great work.
Bitrise✅✅✅ Commit hash: c197911 Note
|
Description
Within the scope of Notifications Project, and due restrictions on both Apple and Google store, the way Snaps will be delivered to mobile users will be in a pre installed approach. Notifications will rely on MM auth
as a snap.
Since preinstalled snaps isn't a feature available on mobile yet, this PR implements a way to enable MetaMask mobile to read from FS an embedded/preInstalled snap, so we can embed auth snap into Mobile App by default.
Related issues
Fixes: Jira Ticket
Manual testing steps
Screenshots/Recordings
After
Pre-merge author checklist
Pre-merge reviewer checklist