-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove cross-fetch
resolution
#8836
Conversation
14ab5ed
to
abe3e90
Compare
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/cross-fetch@2.2.6 |
Bitrise❌❌❌ Commit hash: abe3e90 Note
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8836 +/- ##
=======================================
Coverage 41.61% 41.61%
=======================================
Files 1269 1269
Lines 30869 30869
Branches 3086 3086
=======================================
Hits 12847 12847
Misses 17245 17245
Partials 777 777 ☔ View full report in Codecov by Sentry. |
abe3e90
to
52c6209
Compare
Bitrise❌❌❌ Commit hash: 52c6209 Note
|
This resolution was added in #4249 to update the package in preparation for this package being updated in a controller update. That update happened long ago, and this resolution was not required to update the package in the first place. Today this just prevents the package from being updated.
52c6209
to
7cc668f
Compare
Bitrise✅✅✅ Commit hash: 7cc668f Note
|
Quality Gate passedIssues Measures |
Two E2E failures, but both in different test suites. And neither failure seems related to this package at all (this dependency change only affects the SDK library). It worked the third time though. The failures must have been intermittent failures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This resolution was added in #4249 to update the package in preparation for this package being updated in a controller update. That update happened long ago, and this resolution was not required to update the package in the first place. Today this just prevents the package from being updated.
Related issues
N/A
Manual testing steps
N/A
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist