Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add hideSubmitButton prop to templates #8844

Merged
merged 7 commits into from
Mar 13, 2024
Merged

feat: Add hideSubmitButton prop to templates #8844

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e8b7ae6
Add hideSubmitButton prop to templates
OGPoyraz Mar 5, 2024
b5fb540
Fix suggestoins
OGPoyraz Mar 6, 2024
4328973
Add snapshot tests for TemplateConfirmation
OGPoyraz Mar 6, 2024
984d08c
rename
OGPoyraz Mar 6, 2024
285abd0
update snapshot
OGPoyraz Mar 6, 2024
dc9e21a
Remove fns from prop types
OGPoyraz Mar 12, 2024
e823483
fix tests
OGPoyraz Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions ...nts/Views/confirmations/components/Approval/TemplateConfirmation/TemplateConfirmation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,15 @@ const TemplateConfirmation = ({
[approvalRequest, onConfirm, onCancel, colors],
);

const showActions =
!templatedValues.hideSubmitButton &&
matthewwalsh0 marked this conversation as resolved.
Show resolved Hide resolved
Boolean(
matthewwalsh0 marked this conversation as resolved.
Show resolved Hide resolved
templatedValues.onConfirm ||
onConfirm ||
templatedValues.onCancel ||
onCancel,
);

useEffect(() => {
// Handles the cancellation logic
const handleOnCancel = () => {
Expand Down Expand Up @@ -83,12 +92,14 @@ const TemplateConfirmation = ({
return (
<View style={styles.root}>
<TemplateRenderer sections={templatedValues.content} />
<View style={styles.actionContainer}>
<BottomSheetFooter
buttonsAlignment={ButtonsAlignment.Horizontal}
buttonPropsArray={buttons}
/>
</View>
{showActions && (
matthewwalsh0 marked this conversation as resolved.
Show resolved Hide resolved
<View style={styles.actionContainer}>
<BottomSheetFooter
buttonsAlignment={ButtonsAlignment.Horizontal}
buttonPropsArray={buttons}
/>
</View>
)}
</View>
);
};
Expand Down
2 changes: 2 additions & 0 deletions ...omponents/Views/confirmations/components/Approval/TemplateConfirmation/Templates/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ export interface ConfirmationTemplateValues {
onConfirm?: (opts?: AcceptOptions) => void;
OGPoyraz marked this conversation as resolved.
Show resolved Hide resolved
onlyConfirmButton?: boolean;
OGPoyraz marked this conversation as resolved.
Show resolved Hide resolved
loadingText?: string;
hideSubmitButton?: boolean;
}

export interface ConfirmationTemplate {
Expand Down Expand Up @@ -41,6 +42,7 @@ const ALLOWED_TEMPLATE_KEYS: string[] = [
'onConfirm',
'onlyConfirmButton',
'loadingText',
'hideSubmitButton',
];

export function getTemplateValues(
Expand Down
Loading