-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: network filtered view crash #8846
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise✅✅✅ Commit hash: 17d36c8 Note
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8846 +/- ##
==========================================
- Coverage 41.61% 41.61% -0.01%
==========================================
Files 1269 1269
Lines 30869 30871 +2
Branches 3086 3086
==========================================
Hits 12846 12846
- Misses 17246 17248 +2
Partials 777 777 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Description
Network list filtered view crash when removing the network on the redux state on the add network view and then it's navigating back to the screen, but the list is not updated
This needs to be fixed to move forward with E2E work
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
https://recordit.co/O3haA4sCxZ
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist