-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Gas Fee Controller minor update to version 6.1.0 #8850
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise✅✅✅ Commit hash: 0c45bf0 Note
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/gas-fee-controller@6.0.0 |
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
… network state change , it needs network controller to be updated but it is not a blocker for this update
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8850 +/- ##
=======================================
Coverage 41.61% 41.61%
=======================================
Files 1269 1269
Lines 30871 30871
Branches 3086 3086
=======================================
Hits 12846 12846
Misses 17248 17248
Partials 777 777 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This is a minor update to gas fee controller update
ts-expect-error added on the
onNetworkStateChange
of gas-fee-controller, since does not use the ticker property on this method it isn't blocked by the network controller update to v11Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Sepolia and Linea goerli testnet transactions: https://recordit.co/J3ESQ8hxkR
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist