Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cherry-pick #8861 #8880

Merged
merged 1 commit into from
Mar 7, 2024
Merged

chore: cherry-pick #8861 #8880

merged 1 commit into from
Mar 7, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 7, 2024

This PR cherry-picks #8861

@NicolasMassart @metamaskbot
fix: type for auth events and typo (#8861)
2e64279 
- type for auth events
- fix typo

Fixes #8860
@NicolasMassart NicolasMassart self-assigned this Mar 7, 2024
@NicolasMassart NicolasMassart marked this pull request as ready for review March 7, 2024 21:12
@NicolasMassart NicolasMassart requested a review from a team as a code owner March 7, 2024 21:12
@NicolasMassart NicolasMassart added team-mobile-platform needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed Apply this label when your PR does not need any QA effort. labels Mar 7, 2024
@github-actions github-actions bot added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 7, 2024
@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Mar 7, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2e64279
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/58d10fd3-b4b5-4d16-b69a-fe3bddbfe565

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@NicolasMassart NicolasMassart merged commit 8a59b2c into release/7.18.0 Mar 7, 2024
8 of 10 checks passed
@NicolasMassart NicolasMassart deleted the chore/cherry-pick-8861 branch March 7, 2024 21:40
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 7, 2024
@metamaskbot metamaskbot added the release-7.18.0 Issue or pull request that will be included in release 7.18.0 label Mar 7, 2024
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-7.18.0 on PR, as PR was cherry-picked in branch 7.18.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cortisiko cortisiko cortisiko approved these changes

Assignees

@NicolasMassart NicolasMassart

Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.18.0 Issue or pull request that will be included in release 7.18.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@metamaskbot @cortisiko @NicolasMassart