Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cherry-pick #8829 #8884

Merged
merged 1 commit into from
Mar 12, 2024
Merged

chore: cherry-pick #8829 #8884

merged 1 commit into from
Mar 12, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 8, 2024 •
edited by NicolasMassart
Loading

This PR cherry-picks #8829 (removing all Mixpanel code)

@NicolasMassart @metamaskbot
chore: remove all remaining legacy analytics native code (#8829)
087cfd3 
Remove all Mixpanel analytics native code and dependencies.
Fixes #8795
@NicolasMassart NicolasMassart self-assigned this Mar 8, 2024
@NicolasMassart NicolasMassart marked this pull request as ready for review March 8, 2024 11:23
@NicolasMassart NicolasMassart requested a review from a team as a code owner March 8, 2024 11:23
@github-actions github-actions bot added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 8, 2024
@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Mar 8, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 087cfd3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/36fc35ac-baae-4222-a555-1bee691b35ee

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Cal-L
Cal-L approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NicolasMassart NicolasMassart merged commit bd949dc into release/7.18.0 Mar 12, 2024
6 of 7 checks passed
@NicolasMassart NicolasMassart deleted the chore/cherry-pick-8829 branch March 12, 2024 12:09
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2024
@metamaskbot metamaskbot added the release-7.18.0 Issue or pull request that will be included in release 7.18.0 label Mar 12, 2024
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-7.18.0 on PR, as PR was cherry-picked in branch 7.18.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees

@NicolasMassart NicolasMassart

Labels
release-7.18.0 Issue or pull request that will be included in release 7.18.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@metamaskbot @Cal-L @NicolasMassart