Fix: 8917 user unable to send funds using ledger in v7.17.1 release.

[dawnseeker8]

Description

This PR will fix #8917 for the release 7.17.1.

The fix is quite simple to move the await this.persistTransactionParameters(transaction); above ledger code in Confirm/index.js file so that TransactionController can persist all gas relative tx parameter before ledger process signTransaction.

⚠️ : Due to main branch have TransactionController upgrade which use @ethereumjs/tx library, which cause another issue in ledger transaction flow, this PR will not fix the issue on main branch, however we should still merge this PR to main branch and then i will fix another ledger transaction issue due to @ethereumjs/tx upgrade.

Related issues

Fixes: #8917

Manual testing steps

1. Connect Ledger device
2. Switch network to Linea Testnet
3. Send transaction from Ledger account to Account 2 (normal account)
4. Confirm transaction on Ledger device
5. Transaction should successfully submitted.

Screenshots/Recordings

Before

8917_iPhone.MP4

After

Screen_Recording_20240314_133247_MetaMask.mp4

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7bb7ac2d-80fe-4d29-ad29-a9d2293cf3d9
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/528fbb87-d94e-44ef-835d-4bbb67b29f90
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

[github-actions]

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/156fe5ec-afc8-4d3f-88f1-bb032c505f14
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

[github-actions]

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/48727f9c-70f2-494f-8da2-8a2cd38258cd
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label