-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: 8917 user unable to send funds using ledger in v7.17.1 release. #8933
Conversation
…merged before v7.18.0
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7bb7ac2d-80fe-4d29-ad29-a9d2293cf3d9 |
Quality Gate passedIssues Measures |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/528fbb87-d94e-44ef-835d-4bbb67b29f90 |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/156fe5ec-afc8-4d3f-88f1-bb032c505f14 |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/48727f9c-70f2-494f-8da2-8a2cd38258cd |
Description
This PR will fix #8917 for the release 7.17.1.
The fix is quite simple to move the
await this.persistTransactionParameters(transaction);
above ledger code inConfirm/index.js
file so that TransactionController can persist all gas relative tx parameter before ledger process signTransaction.Related issues
Fixes: #8917
Manual testing steps
Screenshots/Recordings
Before
8917_iPhone.MP4
After
Screen_Recording_20240314_133247_MetaMask.mp4
Pre-merge author checklist
Pre-merge reviewer checklist