-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adding code owner for confirmation domain's code #8987
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Looking at the codeowners validation message, it looks like the team might not exist in this repository? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8987 +/- ##
==========================================
+ Coverage 43.75% 45.56% +1.81%
==========================================
Files 1273 1275 +2
Lines 31113 31169 +56
Branches 3165 3182 +17
==========================================
+ Hits 13612 14203 +591
+ Misses 16688 16125 -563
- Partials 813 841 +28 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Adding code owner for confirmation UX code.
Related issues
Fixes MetaMask/MetaMask-planning#2260
Manual testing steps
NA
Screenshots/Recordings
NA
Pre-merge author checklist
Pre-merge reviewer checklist