-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ramp): use statusDescription in order details #9011
Conversation
Bitrise✅✅✅ Commit hash: b3b0ab7 Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: are these new texts visible by users? If yes, they should be translated, right?
@NicolasMassart Yes they are visible to the users, unfortunately our Ramp API does not have a translation system yet, but it is coming. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9011 +/- ##
=======================================
Coverage 45.58% 45.58%
=======================================
Files 1276 1276
Lines 31301 31301
Branches 3202 3201 -1
=======================================
+ Hits 14269 14270 +1
Misses 16186 16186
+ Partials 846 845 -1 ☔ View full report in Codecov by Sentry. |
@wachunei LGTM for QA ✅ |
Quality Gate passedIssues Measures |
Note
This PR points to #9008, the current PR will point to main once that PR is merged
Description
This PR adopts a new property for the order details status description, this will deliver a description for every possible state.
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/RAMPS-1408
Manual testing steps
Screenshots/Recordings
No visible changes
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist