Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ramp): use statusDescription in order details #9011

Merged
merged 11 commits into from
Apr 26, 2024

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Mar 20, 2024

Note

This PR points to #9008, the current PR will point to main once that PR is merged

Description

This PR adopts a new property for the order details status description, this will deliver a description for every possible state.

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/RAMPS-1408

Manual testing steps

  1. Go to any ramp order details
  2. Pull to refresh, the description must be displayed

Screenshots/Recordings

No visible changes

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features needs-ramp-qa Tickets that need feature QA on the ramps flows labels Mar 20, 2024
@wachunei wachunei marked this pull request as ready for review March 20, 2024 20:07
@wachunei wachunei requested review from a team as code owners March 20, 2024 20:07
@github-actions github-actions bot added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 20, 2024
Copy link
Contributor

github-actions bot commented Mar 20, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b3b0ab7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/30df361f-ee75-4c02-994c-a76e99ab11f3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Base automatically changed from chore/ramp-upgrade-sdk-1.26.8 to main March 21, 2024 16:53
@wachunei wachunei requested a review from a team as a code owner March 21, 2024 16:53
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: are these new texts visible by users? If yes, they should be translated, right?

@wachunei
Copy link
Member Author

@NicolasMassart Yes they are visible to the users, unfortunately our Ramp API does not have a translation system yet, but it is coming.

Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 45.58%. Comparing base (0f7f117) to head (4369022).

Files Patch % Lines
app/components/UI/Ramp/components/OrderDetails.tsx 76.92% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9011   +/-   ##
=======================================
  Coverage   45.58%   45.58%           
=======================================
  Files        1276     1276           
  Lines       31301    31301           
  Branches     3202     3201    -1     
=======================================
+ Hits        14269    14270    +1     
  Misses      16186    16186           
+ Partials      846      845    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 26, 2024
@bkirb
Copy link
Contributor

bkirb commented Apr 26, 2024

@wachunei LGTM for QA ✅

@wachunei wachunei removed the needs-ramp-qa Tickets that need feature QA on the ramps flows label Apr 26, 2024
Copy link

sonarcloud bot commented Apr 26, 2024

@wachunei wachunei merged commit 3bb0d7f into main Apr 26, 2024
31 checks passed
@wachunei wachunei deleted the feat/ramp-order-status-descriptions branch April 26, 2024 19:59
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2024
@metamaskbot metamaskbot added the release-7.23.0 Issue or pull request that will be included in release 7.23.0 label Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.23.0 Issue or pull request that will be included in release 7.23.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-ramp issues related to Ramp features
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants