-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cherry-pick #9023 #9027
chore: cherry-pick #9023 #9027
Conversation
…nent (#9023) ## **Description** This PR enhances the AvatarFavicon component by implementing an SVG validation step using a HEAD request to ensure URIs point to valid SVG files. It improves error handling by setting up a reliable fallback mechanism that activates if the SVG fails to load or doesn't pass validation. The introduction of state management for SVG source validation ensures that only verified SVGs are rendered, thereby minimizing potential rendering issues and improving overall component stability. This streamlined approach enhances user experience by providing a more resilient and error-tolerant AvatarFavicon component. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** https://github.com/MetaMask/metamask-mobile/assets/61094771/61423bae-12b2-4d20-bb55-efeb216d7518 https://github.com/MetaMask/metamask-mobile/assets/61094771/33b13f8a-a1aa-403b-a4fa-a979c36d4909 <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [x] I've linked related issues - [x] I've included manual testing steps - [x] I've included screenshots/recordings if applicable - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I’ve properly set the pull request status: - [x] In case it's not yet "ready for review", I've set it to "draft". - [x] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Bitrise✅✅✅ Commit hash: ac9071a Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - detox smoke test passed
No release label on PR. Adding release label release-7.19.0 on PR, as PR was cherry-picked in branch 7.19.0. |
This PR cherry-picks #9023