Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick: update ppom npm package to version 1.4.5 (#9053) #9063

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Mar 26, 2024

Description

Cherry-pick: update PPOM npm package @blockaid/ppom-release to version 1.4.5.

Related issues

Fixes: #8994

Manual testing steps

  1. Enable blockaid
  2. Submit a malicious transaction in test dapp
  3. Blockaid validations should work as expected

Screenshots/Recordings

NA

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added team-confirmations-secure-ux-PR PR from the confirmations team release-7.19.0 Issue or pull request that will be included in release 7.19.0 labels Mar 26, 2024
@jpuri jpuri requested a review from a team as a code owner March 26, 2024 15:12
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/code-frame@7.24.2 environment +1 29.8 kB nicolo-ribaudo
npm/@babel/compat-data@7.22.20 None 0 64.1 kB nicolo-ribaudo
npm/@babel/helper-string-parser@7.24.1 None 0 31.7 kB nicolo-ribaudo
npm/@babel/highlight@7.24.2 environment +10 175 kB nicolo-ribaudo
npm/@babel/parser@7.24.1 None 0 1.88 MB nicolo-ribaudo
npm/@babel/preset-env@7.22.20 environment Transitive: filesystem, unsafe +106 7.68 MB nicolo-ribaudo
npm/@babel/template@7.24.0 None +2 121 kB nicolo-ribaudo
npm/@babel/types@7.23.0 environment +2 2.47 MB nicolo-ribaudo
npm/@blockaid/ppom_release@1.4.5 network 0 3.32 MB blockaiduser
npm/@jridgewell/gen-mapping@0.3.5 None 0 81.6 kB jridgewell
npm/@jridgewell/set-array@1.2.1 None 0 17.9 kB jridgewell
npm/@jridgewell/trace-mapping@0.3.25 None +1 224 kB jridgewell
npm/@types/estree@1.0.2 None 0 25.7 kB types
npm/browserslist@4.23.0 environment, filesystem Transitive: shell +3 93.7 kB ai
npm/caniuse-lite@1.0.30001600 None 0 2 MB caniuse-lite
npm/core-js-compat@3.32.2 None 0 686 kB zloirock
npm/electron-to-chromium@1.4.717 None 0 282 kB kilianvalkhof
npm/html-inline-script-webpack-plugin@3.2.1 None 0 25.1 kB icelam
npm/node-releases@2.0.14 None 0 34 kB chicoxyzzy
npm/resolve@1.22.6 environment, filesystem +5 216 kB ljharb

🚮 Removed packages: npm/@babel/preset-env@7.22.6, npm/@blockaid/ppom_release@1.2.8, npm/babel-loader@9.1.2, npm/html-inline-script-webpack-plugin@3.2.0, npm/webpack@5.88.1

View full report↗︎

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
New author npm/flat-cache@3.1.0

View full report↗︎

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/flat-cache@3.1.0

Copy link

sonarcloud bot commented Mar 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jpuri jpuri merged commit 626c8d7 into release/7.19.0 Mar 26, 2024
31 of 33 checks passed
@jpuri jpuri deleted the ppom_version_update_1.4.5 branch March 26, 2024 15:26
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.19.0 Issue or pull request that will be included in release 7.19.0 team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants