Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick #9023 #9085

Merged
merged 1 commit into from
Mar 28, 2024
Merged

chore: cherry-pick #9023 #9085

merged 1 commit into from
Mar 28, 2024

Conversation

SamuelSalas
Copy link
Member

@SamuelSalas SamuelSalas commented Mar 28, 2024

This PR cherry-picks #9084

@SamuelSalas SamuelSalas added Run Smoke E2E Triggers smoke e2e on Bitrise release-7.19.0 Issue or pull request that will be included in release 7.19.0 labels Mar 28, 2024
@SamuelSalas SamuelSalas requested a review from a team as a code owner March 28, 2024 03:20
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Mar 28, 2024
Copy link
Contributor

github-actions bot commented Mar 28, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 091ebb8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a5f6b2e9-66f8-4cfb-bb6b-48dc643773bf

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Mar 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release/7.19.0@84fd56b). Click here to learn what that means.

Additional details and impacted files
@@                Coverage Diff                @@
##             release/7.19.0    #9085   +/-   ##
=================================================
  Coverage                  ?   43.73%           
=================================================
  Files                     ?     1273           
  Lines                     ?    31119           
  Branches                  ?     3164           
=================================================
  Hits                      ?    13609           
  Misses                    ?    16697           
  Partials                  ?      813           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman merged commit f34647e into release/7.19.0 Mar 28, 2024
32 of 37 checks passed
@sethkfman sethkfman deleted the chore/cherry-pick-9084 branch March 28, 2024 14:44
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2024
@sethkfman sethkfman added the regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead label Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead release-7.19.0 Issue or pull request that will be included in release 7.19.0 Run Smoke E2E Triggers smoke e2e on Bitrise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants