Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump build from 1288 to 1289 #9089

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

kylanhurt
Copy link
Contributor

Description

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@kylanhurt kylanhurt requested review from a team as code owners March 28, 2024 16:03
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release/7.19.0@f34647e). Click here to learn what that means.

Additional details and impacted files
@@                Coverage Diff                @@
##             release/7.19.0    #9089   +/-   ##
=================================================
  Coverage                  ?   43.73%           
=================================================
  Files                     ?     1273           
  Lines                     ?    31119           
  Branches                  ?     3164           
=================================================
  Hits                      ?    13609           
  Misses                    ?    16697           
  Partials                  ?      813           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Mar 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sethkfman sethkfman merged commit 8cbaf0e into release/7.19.0 Mar 28, 2024
28 of 29 checks passed
@sethkfman sethkfman deleted the chore-version-bump-rc3 branch March 28, 2024 16:28
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2024
@metamaskbot metamaskbot added the release-7.19.0 Issue or pull request that will be included in release 7.19.0 label Mar 29, 2024
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-7.19.0 on PR, as PR was added to branch 7.19.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.19.0 Issue or pull request that will be included in release 7.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants