Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix ses crash resolution #9098

Merged
merged 6 commits into from
Mar 29, 2024

Conversation

sethkfman
Copy link
Contributor

@sethkfman sethkfman commented Mar 29, 2024

Description

This PR make the resolution for the regenerator-runtime more generic fixing crashing SES issue on iOS.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

SES_Crash.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sethkfman sethkfman requested a review from a team as a code owner March 29, 2024 15:11
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman sethkfman added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 29, 2024
Copy link
Contributor

github-actions bot commented Mar 29, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: bf225c3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ffb64058-3f7b-4888-8b63-0e591d1520e9

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sethkfman sethkfman requested a review from a team as a code owner March 29, 2024 15:15
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release/7.19.0@8cbaf0e). Click here to learn what that means.

Additional details and impacted files
@@                Coverage Diff                @@
##             release/7.19.0    #9098   +/-   ##
=================================================
  Coverage                  ?   43.73%           
=================================================
  Files                     ?     1273           
  Lines                     ?    31119           
  Branches                  ?     3164           
=================================================
  Hits                      ?    13609           
  Misses                    ?    16697           
  Partials                  ?      813           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Gudahtt
Gudahtt previously approved these changes Mar 29, 2024
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was one thing I didn't understand with the version bump, but the resolution and lockfile changes LGTM!

@Gudahtt Gudahtt dismissed their stale review March 29, 2024 16:24

Just noticed that a dedupe is required

@sethkfman sethkfman requested a review from Gudahtt March 29, 2024 16:45
Copy link

sonarcloud bot commented Mar 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@kylanhurt kylanhurt added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 29, 2024
Copy link
Contributor

github-actions bot commented Mar 29, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: d20c68a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4ea14dac-f032-4319-b1fc-a65a96e047fd

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sethkfman sethkfman merged commit 04fa71b into release/7.19.0 Mar 29, 2024
27 of 31 checks passed
@sethkfman sethkfman deleted the chore/fix-ses-crash-resolution branch March 29, 2024 18:35
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2024
@metamaskbot metamaskbot added the release-7.19.0 Issue or pull request that will be included in release 7.19.0 label Mar 29, 2024
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-7.19.0 on PR, as PR was added to branch 7.19.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.19.0 Issue or pull request that will be included in release 7.19.0 Run Smoke E2E Triggers smoke e2e on Bitrise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants