-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): upgrade eth-json-rpc-filters, eth-json-rpc-engine #9274
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
b3da306
to
27ade1b
Compare
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/eth-json-rpc-filters@4.2.2 |
53c8a35
to
69be175
Compare
This comment was marked as outdated.
This comment was marked as outdated.
a443778
to
9b7463f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
6cec69d
to
45cfe8d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Looking at it now, the mismatching types due to mismatching versions look like they should be resolved by upgrading |
The failing |
This comment was marked as resolved.
This comment was marked as resolved.
0c1a8a1
to
edecb3c
Compare
edecb3c
to
8920824
Compare
Bitrise🔄🔄🔄 Commit hash: 8920824 Note
|
Quality Gate passedIssues Measures |
Bitrise❌❌❌ Commit hash: 8920824 Note
|
3 similar comments
Bitrise❌❌❌ Commit hash: 8920824 Note
|
Bitrise❌❌❌ Commit hash: 8920824 Note
|
Bitrise❌❌❌ Commit hash: 8920824 Note
|
test: type adjustments
8920824
to
f686da2
Compare
The |
Description
The runtime dependencies
eth-json-rpc-filters
andjson-rpc-engine
are both deprecated. This replaces them with their successors@metamask/eth-json-rpc-filters
and@metamask/json-rpc-engine
, respectively.Related issues
@metamask/transaction-controller
from^13
to min^15
#9931Manual testing steps
n/a
Screenshots/Recordings
Before
n/a
After
n/a
Pre-merge author checklist
Pre-merge reviewer checklist