Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @metamask/eth-json-rpc-middleware #9925

Closed
wants to merge 9 commits into from
Closed

Conversation

MarioAslau
Copy link
Contributor

@MarioAslau MarioAslau commented Jun 10, 2024

Description

We need to add @metamask/eth-json-rpc-middleware v^12 package, and we can remove the used eth-json-rpc-middleware v4 from our package.json

We need also to replace the usage of it on the application (Snaps and BackgroundBridge)
It would also be good to refactor it to use ecmascript (import) instead of commonJS (require) syntax!

Issue: https://github.com/MetaMask/mobile-planning/issues/1805

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Recording.12.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@MarioAslau MarioAslau requested a review from a team as a code owner June 10, 2024 22:31
@MarioAslau MarioAslau self-assigned this Jun 10, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@MarioAslau MarioAslau added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform labels Jun 10, 2024
yarn.lock Outdated
json-stable-stringify "^1.0.1"
pify "^3.0.0"
safe-event-emitter "^1.0.1"

eth-json-rpc-middleware@^6.0.0:
Copy link
Contributor

@legobeat legobeat Jun 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that even after this, eth-json-rpc-middleware@6.0.0 is still used by remaining direct legacy dependencies json-rpc-engine@^6.1.0 and eth-json-rpc-filters@4.2.2.

@MarioAslau
Copy link
Contributor Author

MarioAslau commented Jun 11, 2024

The work on this branch is finished but it will be merged through the PR #9930 that @legobeat made

E2E: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/582806b0-8822-42f7-985f-dae0c8b41b1f

@MarioAslau MarioAslau added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jun 11, 2024
@MarioAslau MarioAslau removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Jun 20, 2024
Copy link

socket-security bot commented Jun 20, 2024

@MarioAslau MarioAslau added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jun 20, 2024
@MarioAslau MarioAslau marked this pull request as ready for review June 20, 2024 17:14
@MarioAslau MarioAslau requested review from a team as code owners June 20, 2024 17:14
@MarioAslau MarioAslau added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jun 20, 2024
Copy link
Contributor

github-actions bot commented Jun 20, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1df1a8e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e1c74716-9933-42fc-9db8-c2c060a4a174

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@MarioAslau MarioAslau added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jun 20, 2024
Copy link
Contributor

github-actions bot commented Jun 20, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a37d6f5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7d4a2403-edb0-425a-a862-5924f7d80ed7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Jun 22, 2024

Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Issues that have not had activity in the last 90 days label Sep 20, 2024
Copy link
Contributor

This PR was closed because there has been no follow up activity in 7 days. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Run Smoke E2E Triggers smoke e2e on Bitrise stale Issues that have not had activity in the last 90 days team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants