-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @metamask/eth-json-rpc-middleware #9925
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
yarn.lock
Outdated
json-stable-stringify "^1.0.1" | ||
pify "^3.0.0" | ||
safe-event-emitter "^1.0.1" | ||
|
||
eth-json-rpc-middleware@^6.0.0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that even after this, eth-json-rpc-middleware@6.0.0
is still used by remaining direct legacy dependencies json-rpc-engine@^6.1.0
and eth-json-rpc-filters@4.2.2
.
- These are upgraded (fully removing
eth-json-rpc-middleware@6.0.0
) in fix(deps): upgrade eth-json-rpc-filters, eth-json-rpc-engine #9274. - Also, in order to properly align on v12: Upgrade
@metamask/transaction-controller
from^13
to min^15
#9931
The work on this branch is finished but it will be merged through the PR #9930 that @legobeat made E2E: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/582806b0-8822-42f7-985f-dae0c8b41b1f |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/eth-json-rpc-middleware@12.1.1, npm/eth-json-rpc-middleware@4.3.0, npm/ethereumjs-common@1.5.2, npm/ethereumjs-tx@1.3.7, npm/level-errors@1.0.5, npm/merkle-patricia-tree@2.3.2 |
Bitrise✅✅✅ Commit hash: 1df1a8e Note
|
Bitrise✅✅✅ Commit hash: a37d6f5 Note
|
Quality Gate passedIssues Measures |
This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions. |
This PR was closed because there has been no follow up activity in 7 days. Thank you for your contributions. |
Description
We need to add @metamask/eth-json-rpc-middleware v^12 package, and we can remove the used eth-json-rpc-middleware v4 from our package.json
We need also to replace the usage of it on the application (Snaps and BackgroundBridge)
It would also be good to refactor it to use ecmascript (import) instead of commonJS (require) syntax!
Issue: https://github.com/MetaMask/mobile-planning/issues/1805
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Recording.12.mp4
Pre-merge author checklist
Pre-merge reviewer checklist