Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [WIP] Test #9274 + #9925 #9930

Closed
wants to merge 16 commits into from
Closed

feat: [WIP] Test #9274 + #9925 #9930

wants to merge 16 commits into from

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Jun 11, 2024

Description

This branch exists to sample combination of:

In order to consistently upgrade json-rpc-middleware/@metamask/json-rpc-middleware and related deps.

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat added dependencies Pull requests that update a dependency file team-security labels Jun 11, 2024
Copy link

socket-security bot commented Jun 11, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/eth-json-rpc-filters@7.0.0 None +1 36.4 kB lgbot

🚮 Removed packages: npm/eth-json-rpc-filters@4.2.2, npm/eth-json-rpc-middleware@4.3.0, npm/ethereumjs-common@1.5.2, npm/ethereumjs-tx@1.3.7, npm/level-errors@1.0.5, npm/merkle-patricia-tree@2.3.2

View full report↗︎

@legobeat legobeat changed the title [WIP] Test #9274 + #9925 feat: [WIP] Test #9274 + #9925 Jun 11, 2024
Copy link

socket-security bot commented Jun 11, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
New author npm/jsonify@0.0.1
  • New Author: ljharb
  • Previous Author:
🚫

View full report↗︎

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/jsonify@0.0.1

@legobeat legobeat added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jun 11, 2024
Copy link
Contributor

github-actions bot commented Jun 11, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e160aa5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/90642c6c-9c17-4a58-a990-9fba0b18d005

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jun 11, 2024
Copy link
Contributor

github-actions bot commented Jun 11, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 98fba92
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/73196709-a972-46e9-b7ff-8fca48d5639e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@MarioAslau MarioAslau added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jun 11, 2024
Copy link
Contributor

github-actions bot commented Jun 11, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 242934d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/64c2df1d-c2b7-4666-8bfa-d6fb1f1b6801

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@MarioAslau MarioAslau added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jun 11, 2024
Copy link
Contributor

github-actions bot commented Jun 11, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6cfbed3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3e092a82-07f9-455a-a90f-87ada120f9f8

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Jun 20, 2024

@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jun 20, 2024
Copy link
Contributor

github-actions bot commented Jun 20, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: dfae3be
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/97fe7cf0-5b2b-4e7e-8583-3c075337a198

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat
Copy link
Contributor Author

Closed in favor of #10098

@legobeat legobeat closed this Jun 25, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file Run Smoke E2E Triggers smoke e2e on Bitrise team-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants