Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Synchronise package with module template (July 2023) (#98)" #103

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Aug 23, 2023

This reverts commit ab0ebca (#98).

As #98 removes the ability to import or require from paths like
@metamask/rpc-errors/dist/foo and a release is still pending for the
current major, this will have to be temporarily reverted.

After a 5.x release has been made addressing #100 , this change can be reintroduced.

Related:

…k#98)"

This reverts commit ab0ebca.

As MetaMask#98 removes the ability to import or require from paths like
 `@metamask/rpc-errors/dist/foo` and a release is still pending for the
 current major, this will have to be temporarily reverted.
@legobeat legobeat requested review from mcmire, Mrtenz and a team August 23, 2023 14:16
@socket-security
Copy link

socket-security bot commented Aug 23, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: @metamask/eslint-config-jest@11.1.0, sshpk@1.17.0, uuid@3.4.0, ecc-jsbn@0.1.2, bcrypt-pbkdf@1.0.2, eslint-plugin-node@11.1.0, jsbn@0.1.1

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@legobeat
Copy link
Contributor Author

@SocketSecurity ignore @metamask/eslint-config-jest@11.1.0
@SocketSecurity ignore sshpk@1.17.0
@SocketSecurity ignore uuid@3.4.0
@SocketSecurity ignore ecc-jsbn@0.1.2
@SocketSecurity ignore bcrypt-pbkdf@1.0.2
@SocketSecurity ignore eslint-plugin-node@11.1.0
@SocketSecurity ignore jsbn@0.1.1

@legobeat legobeat marked this pull request as ready for review August 23, 2023 14:18
@legobeat legobeat requested a review from a team as a code owner August 23, 2023 14:18
@legobeat legobeat merged commit b91c7e8 into MetaMask:main Aug 23, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants