Bump @metamask/eslint-config from 11.1.0 to 12.0.0 (#1576)

* Bump @metamask/eslint-config from 11.1.0 to 12.0.0 Bumps [@metamask/eslint-config](https://github.com/MetaMask/eslint-config) from 11.1.0 to 12.0.0. - [Release notes](https://github.com/MetaMask/eslint-config/releases) - [Commits](MetaMask/eslint-config@v11.1.0...v12.0.0) --- updated-dependencies: - dependency-name: "@metamask/eslint-config" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Bump all ESLint-related dependencies * Run yarn lint:fix * Fix create-snap lint issues * Fix snaps-cli lint issues * Fix snaps-controllers lint issues * Fix snaps-execution-environments lint issues * Fix snaps-jest lint issues * Fix snaps-simulator lint issues * Fix snaps-utils lint issues * Update LavaMoat policies and snap shasums * Add missing shebang --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
MetaMask · Jul 14, 2023 · 2908e7f · 2908e7f
1 parent d0a505c
commit 2908e7f
Show file tree

Hide file tree

Showing 371 changed files with 1,464 additions and 1,468 deletions.
diff --git a/package.json b/package.json
@@ -62,10 +62,10 @@
   "devDependencies": {
     "@lavamoat/allow-scripts": "^2.3.1",
     "@metamask/auto-changelog": "^3.1.0",
-    "@metamask/eslint-config": "^11.0.0",
-    "@metamask/eslint-config-jest": "^11.0.0",
-    "@metamask/eslint-config-nodejs": "^11.0.1",
-    "@metamask/eslint-config-typescript": "^11.0.0",
+    "@metamask/eslint-config": "^12.0.0",
+    "@metamask/eslint-config-jest": "^12.0.0",
+    "@metamask/eslint-config-nodejs": "^12.0.0",
+    "@metamask/eslint-config-typescript": "^12.0.0",
     "@metamask/utils": "^6.0.1",
     "@swc/cli": "^0.1.62",
     "@swc/core": "^1.3.66",
@@ -79,8 +79,9 @@
     "eslint-plugin-import": "^2.26.0",
     "eslint-plugin-jest": "^27.1.5",
     "eslint-plugin-jsdoc": "^39.6.2",
-    "eslint-plugin-node": "^11.1.0",
+    "eslint-plugin-n": "^15.7.0",
     "eslint-plugin-prettier": "^4.2.1",
+    "eslint-plugin-promise": "^6.1.1",
     "execa": "^5.1.1",
     "favicons": "^7.1.2",
     "geckodriver": "^3.2.0",

diff --git a/packages/create-snap/.eslintrc.js b/packages/create-snap/.eslintrc.js
@@ -14,24 +14,10 @@ module.exports = {
       },
     },
 
-    {
-      files: ['src/**/*', 'scripts/**/*'],
-      rules: {
-        'node/no-process-exit': 'off',
-      },
-    },
-
     {
       files: ['src/main.ts'],
       rules: {
-        'node/shebang': 'off',
-      },
-    },
-
-    {
-      files: ['**/*.test.ts'],
-      rules: {
-        'node/no-callback-literal': 'off',
+        'n/shebang': 'off',
       },
     },
   ],

diff --git a/packages/create-snap/package.json b/packages/create-snap/package.json
@@ -58,10 +58,10 @@
   "devDependencies": {
     "@lavamoat/allow-scripts": "^2.3.1",
     "@metamask/auto-changelog": "^3.1.0",
-    "@metamask/eslint-config": "^11.0.0",
-    "@metamask/eslint-config-jest": "^11.0.0",
-    "@metamask/eslint-config-nodejs": "^11.0.1",
-    "@metamask/eslint-config-typescript": "^11.0.0",
+    "@metamask/eslint-config": "^12.0.0",
+    "@metamask/eslint-config-jest": "^12.0.0",
+    "@metamask/eslint-config-nodejs": "^12.0.0",
+    "@metamask/eslint-config-typescript": "^12.0.0",
     "@swc/cli": "^0.1.62",
     "@swc/core": "^1.3.66",
     "@swc/jest": "^0.2.26",
@@ -77,8 +77,9 @@
     "eslint-plugin-import": "^2.26.0",
     "eslint-plugin-jest": "^27.1.5",
     "eslint-plugin-jsdoc": "^39.6.2",
-    "eslint-plugin-node": "^11.1.0",
+    "eslint-plugin-n": "^15.7.0",
     "eslint-plugin-prettier": "^4.2.1",
+    "eslint-plugin-promise": "^6.1.1",
     "jest": "^29.0.2",
     "jest-it-up": "^2.0.0",
     "memfs": "^3.4.13",

diff --git a/packages/create-snap/src/builders.ts b/packages/create-snap/src/builders.ts
@@ -1,4 +1,4 @@
-import { Options, PositionalOptions } from 'yargs';
+import type { Options, PositionalOptions } from 'yargs';
 
 export type SnapsCliBuilders = {
   readonly verboseErrors: Readonly<Options>;

diff --git a/packages/create-snap/src/cmds/init/index.ts b/packages/create-snap/src/cmds/init/index.ts
@@ -1,8 +1,8 @@
 import { logInfo } from '@metamask/snaps-utils';
-import yargs from 'yargs';
+import type yargs from 'yargs';
 
 import builders from '../../builders';
-import { YargsArgs } from '../../types/yargs';
+import type { YargsArgs } from '../../types/yargs';
 import { initHandler } from './initHandler';
 
 export const initCommand = {

diff --git a/packages/create-snap/src/cmds/init/initHandler.test.ts b/packages/create-snap/src/cmds/init/initHandler.test.ts
@@ -5,7 +5,7 @@ import { promises as fs } from 'fs';
 import pathUtils from 'path';
 
 import { resetFileSystem } from '../../test-utils';
-import { YargsArgs } from '../../types/yargs';
+import type { YargsArgs } from '../../types/yargs';
 import { initHandler } from './initHandler';
 import * as initUtils from './initUtils';
 

diff --git a/packages/create-snap/src/cmds/init/initHandler.ts b/packages/create-snap/src/cmds/init/initHandler.ts
@@ -1,19 +1,16 @@
+import type { NpmSnapPackageJson } from '@metamask/snaps-utils';
 import {
   NpmSnapFileNames,
   readJsonFile,
-  NpmSnapPackageJson,
   createSnapManifest,
   logInfo,
 } from '@metamask/snaps-utils';
-import {
-  satisfiesVersionRange,
-  SemVerRange,
-  SemVerVersion,
-} from '@metamask/utils';
+import type { SemVerRange, SemVerVersion } from '@metamask/utils';
+import { satisfiesVersionRange } from '@metamask/utils';
 import { promises as fs } from 'fs';
 import pathUtils from 'path';
 
-import { YargsArgs } from '../../types/yargs';
+import type { YargsArgs } from '../../types/yargs';
 import {
   buildSnap,
   cloneTemplate,

diff --git a/packages/create-snap/src/main.ts b/packages/create-snap/src/main.ts
@@ -1,5 +1,4 @@
 #!/usr/bin/env node
-
 import { cli } from './cli';
 
 cli(process.argv);
diff --git a/packages/create-snap/src/types/yargs.d.ts b/packages/create-snap/src/types/yargs.d.ts
@@ -1,7 +1,7 @@
-import { Options } from 'yargs';
+import type { Options } from 'yargs';
 
 // eslint-disable-next-line @typescript-eslint/ban-types
-type OptionalArguments<T = {}> = T & {
+type OptionalArguments<Type = {}> = Type & {
   /** Non-option arguments */
   _?: (string | number)[];
 

diff --git a/packages/examples/package.json b/packages/examples/package.json
@@ -30,19 +30,20 @@
   "devDependencies": {
     "@lavamoat/allow-scripts": "^2.3.1",
     "@metamask/auto-changelog": "^3.1.0",
-    "@metamask/eslint-config": "^11.0.0",
-    "@metamask/eslint-config-jest": "^11.0.0",
-    "@metamask/eslint-config-nodejs": "^11.0.1",
-    "@metamask/eslint-config-typescript": "^11.0.0",
+    "@metamask/eslint-config": "^12.0.0",
+    "@metamask/eslint-config-jest": "^12.0.0",
+    "@metamask/eslint-config-nodejs": "^12.0.0",
+    "@metamask/eslint-config-typescript": "^12.0.0",
     "@typescript-eslint/eslint-plugin": "^5.42.1",
     "@typescript-eslint/parser": "^5.42.1",
     "eslint": "^8.27.0",
     "eslint-config-prettier": "^8.5.0",
     "eslint-plugin-import": "^2.26.0",
     "eslint-plugin-jest": "^27.1.5",
     "eslint-plugin-jsdoc": "^39.6.2",
-    "eslint-plugin-node": "^11.1.0",
+    "eslint-plugin-n": "^15.7.0",
     "eslint-plugin-prettier": "^4.2.1",
+    "eslint-plugin-promise": "^6.1.1",
     "prettier": "^2.7.1",
     "prettier-plugin-packagejson": "^2.2.11",
     "ts-node": "^10.9.1",

diff --git a/packages/examples/packages/bip32/package.json b/packages/examples/packages/bip32/package.json
@@ -43,10 +43,10 @@
     "@jest/globals": "^29.5.0",
     "@lavamoat/allow-scripts": "^2.3.1",
     "@metamask/auto-changelog": "^3.1.0",
-    "@metamask/eslint-config": "^11.0.0",
-    "@metamask/eslint-config-jest": "^11.0.0",
-    "@metamask/eslint-config-nodejs": "^11.0.1",
-    "@metamask/eslint-config-typescript": "^11.0.0",
+    "@metamask/eslint-config": "^12.0.0",
+    "@metamask/eslint-config-jest": "^12.0.0",
+    "@metamask/eslint-config-nodejs": "^12.0.0",
+    "@metamask/eslint-config-typescript": "^12.0.0",
     "@metamask/snaps-cli": "workspace:^",
     "@metamask/snaps-jest": "workspace:^",
     "@swc/core": "^1.3.66",
@@ -59,8 +59,9 @@
     "eslint-plugin-import": "^2.26.0",
     "eslint-plugin-jest": "^27.1.5",
     "eslint-plugin-jsdoc": "^39.6.2",
-    "eslint-plugin-node": "^11.1.0",
+    "eslint-plugin-n": "^15.7.0",
     "eslint-plugin-prettier": "^4.2.1",
+    "eslint-plugin-promise": "^6.1.1",
     "jest": "^29.0.2",
     "prettier": "^2.7.1",
     "prettier-plugin-packagejson": "^2.2.11",

diff --git a/packages/examples/packages/bip32/src/index.ts b/packages/examples/packages/bip32/src/index.ts
@@ -1,5 +1,6 @@
 import { providerErrors, rpcErrors } from '@metamask/rpc-errors';
-import { DialogType, OnRpcRequestHandler } from '@metamask/snaps-types';
+import type { OnRpcRequestHandler } from '@metamask/snaps-types';
+import { DialogType } from '@metamask/snaps-types';
 import { panel, text, heading, copyable } from '@metamask/snaps-ui';
 import {
   add0x,
@@ -11,7 +12,7 @@ import {
 import { sign as signEd25519 } from '@noble/ed25519';
 import { sign as signSecp256k1 } from '@noble/secp256k1';
 
-import { GetBip32PublicKeyParams, SignMessageParams } from './types';
+import type { GetBip32PublicKeyParams, SignMessageParams } from './types';
 import { getPrivateNode, getPublicKey } from './utils';
 
 /**

diff --git a/packages/examples/packages/bip32/src/utils.ts b/packages/examples/packages/bip32/src/utils.ts
@@ -1,6 +1,6 @@
 import { SLIP10Node } from '@metamask/key-tree';
 
-import { GetBip32PublicKeyParams, SignMessageParams } from './types';
+import type { GetBip32PublicKeyParams, SignMessageParams } from './types';
 
 /**
  * Get an extended private key BIP-32 node, using the `snap_getBip32Entropy`

diff --git a/packages/examples/packages/bip44/package.json b/packages/examples/packages/bip44/package.json
@@ -42,10 +42,10 @@
     "@jest/globals": "^29.5.0",
     "@lavamoat/allow-scripts": "^2.3.1",
     "@metamask/auto-changelog": "^3.1.0",
-    "@metamask/eslint-config": "^11.0.0",
-    "@metamask/eslint-config-jest": "^11.0.0",
-    "@metamask/eslint-config-nodejs": "^11.0.1",
-    "@metamask/eslint-config-typescript": "^11.0.0",
+    "@metamask/eslint-config": "^12.0.0",
+    "@metamask/eslint-config-jest": "^12.0.0",
+    "@metamask/eslint-config-nodejs": "^12.0.0",
+    "@metamask/eslint-config-typescript": "^12.0.0",
     "@metamask/snaps-cli": "workspace:^",
     "@metamask/snaps-jest": "workspace:^",
     "@swc/core": "^1.3.66",
@@ -58,8 +58,9 @@
     "eslint-plugin-import": "^2.26.0",
     "eslint-plugin-jest": "^27.1.5",
     "eslint-plugin-jsdoc": "^39.6.2",
-    "eslint-plugin-node": "^11.1.0",
+    "eslint-plugin-n": "^15.7.0",
     "eslint-plugin-prettier": "^4.2.1",
+    "eslint-plugin-promise": "^6.1.1",
     "jest": "^29.0.2",
     "prettier": "^2.7.1",
     "prettier-plugin-packagejson": "^2.2.11",

diff --git a/packages/examples/packages/bip44/src/index.ts b/packages/examples/packages/bip44/src/index.ts
@@ -1,10 +1,11 @@
 import { rpcErrors, providerErrors } from '@metamask/rpc-errors';
-import { DialogType, OnRpcRequestHandler } from '@metamask/snaps-types';
+import type { OnRpcRequestHandler } from '@metamask/snaps-types';
+import { DialogType } from '@metamask/snaps-types';
 import { panel, text, heading, copyable } from '@metamask/snaps-ui';
 import { bytesToHex, stringToBytes } from '@metamask/utils';
 import { getPublicKey, sign } from '@noble/bls12-381';
 
-import { GetAccountParams, SignMessageParams } from './types';
+import type { GetAccountParams, SignMessageParams } from './types';
 import { getPrivateKey } from './utils';
 
 /**

diff --git a/packages/examples/packages/bip44/src/utils.ts b/packages/examples/packages/bip44/src/utils.ts
@@ -1,7 +1,7 @@
 import { deriveBIP44AddressKey } from '@metamask/key-tree';
 import { assert, remove0x } from '@metamask/utils';
 
-import { GetAccountParams } from './types';
+import type { GetAccountParams } from './types';
 
 /**
  * Get a BIP-44 private key, using the `snap_getBip44Entropy` method.

diff --git a/packages/examples/packages/browserify-plugin/package.json b/packages/examples/packages/browserify-plugin/package.json
@@ -37,10 +37,10 @@
     "@jest/globals": "^29.5.0",
     "@lavamoat/allow-scripts": "^2.3.1",
     "@metamask/auto-changelog": "^3.1.0",
-    "@metamask/eslint-config": "^11.0.0",
-    "@metamask/eslint-config-jest": "^11.0.0",
-    "@metamask/eslint-config-nodejs": "^11.0.1",
-    "@metamask/eslint-config-typescript": "^11.0.0",
+    "@metamask/eslint-config": "^12.0.0",
+    "@metamask/eslint-config-jest": "^12.0.0",
+    "@metamask/eslint-config-nodejs": "^12.0.0",
+    "@metamask/eslint-config-typescript": "^12.0.0",
     "@metamask/snaps-browserify-plugin": "workspace:^",
     "@metamask/snaps-jest": "workspace:^",
     "@swc/core": "^1.3.66",
@@ -55,8 +55,9 @@
     "eslint-plugin-import": "^2.26.0",
     "eslint-plugin-jest": "^27.1.5",
     "eslint-plugin-jsdoc": "^39.6.2",
-    "eslint-plugin-node": "^11.1.0",
+    "eslint-plugin-n": "^15.7.0",
     "eslint-plugin-prettier": "^4.2.1",
+    "eslint-plugin-promise": "^6.1.1",
     "jest": "^29.0.2",
     "prettier": "^2.7.1",
     "prettier-plugin-packagejson": "^2.2.11",

diff --git a/packages/examples/packages/browserify-plugin/src/index.ts b/packages/examples/packages/browserify-plugin/src/index.ts
@@ -1,5 +1,5 @@
 import { rpcErrors } from '@metamask/rpc-errors';
-import { OnRpcRequestHandler } from '@metamask/snaps-types';
+import type { OnRpcRequestHandler } from '@metamask/snaps-types';
 
 /**
  * Handle incoming JSON-RPC requests from the dapp, sent through the

diff --git a/packages/examples/packages/cronjobs/package.json b/packages/examples/packages/cronjobs/package.json
@@ -39,10 +39,10 @@
     "@jest/globals": "^29.5.0",
     "@lavamoat/allow-scripts": "^2.3.1",
     "@metamask/auto-changelog": "^3.1.0",
-    "@metamask/eslint-config": "^11.0.0",
-    "@metamask/eslint-config-jest": "^11.0.0",
-    "@metamask/eslint-config-nodejs": "^11.0.1",
-    "@metamask/eslint-config-typescript": "^11.0.0",
+    "@metamask/eslint-config": "^12.0.0",
+    "@metamask/eslint-config-jest": "^12.0.0",
+    "@metamask/eslint-config-nodejs": "^12.0.0",
+    "@metamask/eslint-config-typescript": "^12.0.0",
     "@metamask/snaps-cli": "workspace:^",
     "@metamask/snaps-jest": "workspace:^",
     "@swc/core": "^1.3.66",
@@ -55,8 +55,9 @@
     "eslint-plugin-import": "^2.26.0",
     "eslint-plugin-jest": "^27.1.5",
     "eslint-plugin-jsdoc": "^39.6.2",
-    "eslint-plugin-node": "^11.1.0",
+    "eslint-plugin-n": "^15.7.0",
     "eslint-plugin-prettier": "^4.2.1",
+    "eslint-plugin-promise": "^6.1.1",
     "jest": "^29.0.2",
     "prettier": "^2.7.1",
     "prettier-plugin-packagejson": "^2.2.11",

diff --git a/packages/examples/packages/cronjobs/src/index.ts b/packages/examples/packages/cronjobs/src/index.ts
@@ -1,5 +1,5 @@
 import { rpcErrors } from '@metamask/rpc-errors';
-import { OnCronjobHandler } from '@metamask/snaps-types';
+import type { OnCronjobHandler } from '@metamask/snaps-types';
 import { panel, text, heading } from '@metamask/snaps-ui';
 
 /**

diff --git a/packages/examples/packages/dialogs/package.json b/packages/examples/packages/dialogs/package.json
@@ -40,10 +40,10 @@
     "@jest/globals": "^29.5.0",
     "@lavamoat/allow-scripts": "^2.3.1",
     "@metamask/auto-changelog": "^3.1.0",
-    "@metamask/eslint-config": "^11.0.0",
-    "@metamask/eslint-config-jest": "^11.0.0",
-    "@metamask/eslint-config-nodejs": "^11.0.1",
-    "@metamask/eslint-config-typescript": "^11.0.0",
+    "@metamask/eslint-config": "^12.0.0",
+    "@metamask/eslint-config-jest": "^12.0.0",
+    "@metamask/eslint-config-nodejs": "^12.0.0",
+    "@metamask/eslint-config-typescript": "^12.0.0",
     "@metamask/snaps-cli": "workspace:^",
     "@metamask/snaps-jest": "workspace:^",
     "@metamask/utils": "^6.0.1",
@@ -57,8 +57,9 @@
     "eslint-plugin-import": "^2.26.0",
     "eslint-plugin-jest": "^27.1.5",
     "eslint-plugin-jsdoc": "^39.6.2",
-    "eslint-plugin-node": "^11.1.0",
+    "eslint-plugin-n": "^15.7.0",
     "eslint-plugin-prettier": "^4.2.1",
+    "eslint-plugin-promise": "^6.1.1",
     "jest": "^29.0.2",
     "prettier": "^2.7.1",
     "prettier-plugin-packagejson": "^2.2.11",

diff --git a/packages/examples/packages/dialogs/src/index.ts b/packages/examples/packages/dialogs/src/index.ts
@@ -1,5 +1,6 @@
 import { rpcErrors } from '@metamask/rpc-errors';
-import { OnRpcRequestHandler, DialogType } from '@metamask/snaps-types';
+import type { OnRpcRequestHandler } from '@metamask/snaps-types';
+import { DialogType } from '@metamask/snaps-types';
 import { panel, text, heading } from '@metamask/snaps-ui';
 
 /**

diff --git a/packages/examples/packages/errors/package.json b/packages/examples/packages/errors/package.json
@@ -37,10 +37,10 @@
     "@jest/globals": "^29.5.0",
     "@lavamoat/allow-scripts": "^2.3.1",
     "@metamask/auto-changelog": "^3.1.0",
-    "@metamask/eslint-config": "^11.0.0",
-    "@metamask/eslint-config-jest": "^11.0.0",
-    "@metamask/eslint-config-nodejs": "^11.0.1",
-    "@metamask/eslint-config-typescript": "^11.0.0",
+    "@metamask/eslint-config": "^12.0.0",
+    "@metamask/eslint-config-jest": "^12.0.0",
+    "@metamask/eslint-config-nodejs": "^12.0.0",
+    "@metamask/eslint-config-typescript": "^12.0.0",
     "@metamask/snaps-cli": "workspace:^",
     "@metamask/snaps-jest": "workspace:^",
     "@swc/core": "^1.3.66",
@@ -53,8 +53,9 @@
     "eslint-plugin-import": "^2.26.0",
     "eslint-plugin-jest": "^27.1.5",
     "eslint-plugin-jsdoc": "^39.6.2",
-    "eslint-plugin-node": "^11.1.0",
+    "eslint-plugin-n": "^15.7.0",
     "eslint-plugin-prettier": "^4.2.1",
+    "eslint-plugin-promise": "^6.1.1",
     "jest": "^29.0.2",
     "prettier": "^2.7.1",
     "prettier-plugin-packagejson": "^2.2.11",