Skip to content

Commit

Permalink
snaps-controllers: @metamask/rpc-errors migration
Browse files Browse the repository at this point in the history
  • Loading branch information
legobeat committed Sep 7, 2023
1 parent 0174aa4 commit a6d09ec
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 17 deletions.
8 changes: 4 additions & 4 deletions packages/snaps-controllers/src/snaps/SnapController.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -848,7 +848,7 @@ describe('SnapController', () => {
id: expect.any(String),
requestState: {
loading: false,
error: ethErrors.provider.userRejectedRequest().message,
error: providerErrors.userRejectedRequest().message,
type: SNAP_APPROVAL_INSTALL,
},
}),
Expand Down Expand Up @@ -1657,7 +1657,7 @@ describe('SnapController', () => {
},
}),
).rejects.toThrow(
ethErrors.rpc.invalidRequest({
rpcErrors.invalidRequest({
message:
'Invalid JSON-RPC request: At path: jsonrpc -- Expected the literal `"2.0"`, but received: "kaplar".',
}),
Expand Down Expand Up @@ -2283,7 +2283,7 @@ describe('SnapController', () => {
id: expect.any(String),
requestState: {
loading: false,
error: ethErrors.provider.userRejectedRequest().message,
error: providerErrors.userRejectedRequest().message,
type: SNAP_APPROVAL_INSTALL,
},
}),
Expand Down Expand Up @@ -3445,7 +3445,7 @@ describe('SnapController', () => {
detectSnapLocation(),
),
).rejects.toThrow(
ethErrors.rpc.invalidParams(
rpcErrors.invalidParams(
`Snap "${MOCK_SNAP_ID}@${snap.version}" is already installed. Couldn't update to a version inside requested "*" range.`,
),
);
Expand Down
6 changes: 3 additions & 3 deletions packages/snaps-controllers/src/snaps/SnapController.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1660,7 +1660,7 @@ export class SnapController extends BaseController<
const [error, version] = resolveVersionRange(rawVersion);

if (error) {
throw ethErrors.rpc.invalidParams(
throw rpcErrors.invalidParams(
`The "version" field must be a valid SemVer version range if specified. Received: "${rawVersion}".`,
);
}
Expand Down Expand Up @@ -1738,7 +1738,7 @@ export class SnapController extends BaseController<
if (this.#featureFlags.dappsCanUpdateSnaps === true) {
return await this.updateSnap(origin, snapId, location, versionRange);
}
throw ethErrors.rpc.invalidParams(
throw rpcErrors.invalidParams(
`Version mismatch with already installed snap. ${snapId}@${existingSnap.version} doesn't satisfy requested version ${versionRange}.`,
);
}
Expand Down Expand Up @@ -1888,7 +1888,7 @@ export class SnapController extends BaseController<

const newVersion = newSnap.manifest.result.version;
if (!gtVersion(newVersion, snap.version)) {
throw ethErrors.rpc.invalidParams(
throw rpcErrors.invalidParams(
`Snap "${snapId}@${snap.version}" is already installed. Couldn't update to a version inside requested "${newVersionRange}" range.`,
);
}
Expand Down
6 changes: 3 additions & 3 deletions packages/snaps-controllers/src/snaps/endowments/cronjob.ts
Original file line number Diff line number Diff line change
Expand Up @@ -109,21 +109,21 @@ export function getCronjobCaveatJobs(
*/
export function validateCronjobCaveat(caveat: Caveat<string, any>) {
if (!hasProperty(caveat, 'value') || !isPlainObject(caveat.value)) {
throw ethErrors.rpc.invalidParams({
throw rpcErrors.invalidParams({
message: 'Expected a plain object.',
});
}

const { value } = caveat;

if (!hasProperty(value, 'jobs') || !isPlainObject(value)) {
throw ethErrors.rpc.invalidParams({
throw rpcErrors.invalidParams({
message: 'Expected a plain object.',
});
}

if (!isCronjobSpecificationArray(value.jobs)) {
throw ethErrors.rpc.invalidParams({
throw rpcErrors.invalidParams({
message: 'Expected a valid cronjob specification array.',
});
}
Expand Down
6 changes: 3 additions & 3 deletions packages/snaps-controllers/src/snaps/endowments/rpc.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ const specificationBuilder: PermissionSpecificationBuilder<
caveats?.length !== 1 ||
caveats[0].type !== SnapCaveatType.RpcOrigin
) {
throw ethErrors.rpc.invalidParams({
throw rpcErrors.invalidParams({
message: `Expected a single "${SnapCaveatType.RpcOrigin}" caveat.`,
});
}
Expand All @@ -75,13 +75,13 @@ export const rpcEndowmentBuilder = Object.freeze({
*/
function validateCaveatOrigins(caveat: Caveat<string, any>) {
if (!hasProperty(caveat, 'value') || !isPlainObject(caveat.value)) {
throw ethErrors.rpc.invalidParams({
throw rpcErrors.invalidParams({
message: 'Invalid JSON-RPC origins: Expected a plain object.',
});
}

const { value } = caveat;
assertIsRpcOrigins(value, ethErrors.rpc.invalidParams);
assertIsRpcOrigins(value, rpcErrors.invalidParams);
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ const specificationBuilder: PermissionSpecificationBuilder<
(caveats?.length === 1 &&
caveats[0].type !== SnapCaveatType.TransactionOrigin)
) {
throw ethErrors.rpc.invalidParams({
throw rpcErrors.invalidParams({
message: `Expected a single "${SnapCaveatType.TransactionOrigin}" caveat.`,
});
}
Expand All @@ -70,7 +70,7 @@ export const transactionInsightEndowmentBuilder = Object.freeze({
*/
function validateCaveat(caveat: Caveat<string, any>): void {
if (!hasProperty(caveat, 'value') || !isPlainObject(caveat)) {
throw ethErrors.rpc.invalidParams({
throw rpcErrors.invalidParams({
message: 'Expected a plain object.',
});
}
Expand Down
4 changes: 2 additions & 2 deletions packages/snaps-controllers/src/test-utils/controller.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import {
MOCK_SNAP_ID,
} from '@metamask/snaps-utils/test-utils';
import type { Json } from '@metamask/utils';
import { rpcErrors } from '@metamask/rpc-errors';
import { providerErrors } from '@metamask/rpc-errors';

Check failure on line 22 in packages/snaps-controllers/src/test-utils/controller.ts

View workflow job for this annotation

GitHub Actions / Build, lint, and test / Lint (@metamask/snaps-controllers)

`@metamask/rpc-errors` import should occur before import of `@metamask/rpc-methods`

import type {
CronjobControllerActions,
Expand Down Expand Up @@ -88,7 +88,7 @@ export class MockApprovalController {
}) {
if (this.#approval) {
if (requestState.loading === false && !requestState.error) {
this.#approval.promise.reject(ethErrors.provider.userRejectedRequest());
this.#approval.promise.reject(providerErrors.userRejectedRequest());
}
}
}
Expand Down

0 comments on commit a6d09ec

Please sign in to comment.