Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump @metamask/providers from 11.1.1 to 13.0.0 #1748

Closed
wants to merge 9 commits into from
Closed

Bump @metamask/providers from 11.1.1 to 13.0.0 #1748

wants to merge 9 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 18, 2023 •
edited
Loading

Bumps @metamask/providers from 11.1.1 to 13.0.0.

Release notes

Sourced from @​metamask/providers's releases.

12.0.0

Changed

  • BREAKING: Replace eth-rpc-errors@^4.0.2 with @metamask/rpc-errors@6.0.0 (#277)
  • BREAKING: Replace json-rpc-engine@^6.1.0 with @metamask/json-rpc-engine@7.1.1 (#277)
  • Upgrade @metamask/utils from ^6.2.0 to ^8.1.0 (#277)

11.1.2

Changed

  • Update extension-port-stream to ^2.1.1 (#273)
Changelog

Sourced from @​metamask/providers's changelog.

[13.0.0]

Changed

  • BREAKING: Update chainId, networkVersion, and selectedAddress to be read-only (#280)
  • Log deprecation warning when accessing chainId, networkVersion, and selectedAddress (#280)
  • Remove pump (#281)

[12.0.0]

Changed

  • BREAKING: Replace eth-rpc-errors@^4.0.2 with @metamask/rpc-errors@6.0.0 (#277)
  • BREAKING: Replace json-rpc-engine@^6.1.0 with @metamask/json-rpc-engine@7.1.1 (#277)
  • Upgrade @metamask/utils from ^6.2.0 to ^8.1.0 (#277)

[11.1.2]

Changed

  • Update extension-port-stream to ^2.1.1 (#273)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
Bump @metamask/providers from 11.1.1 to 13.0.0
09394e2 
Bumps [@metamask/providers](https://github.com/MetaMask/providers) from 11.1.1 to 13.0.0.
- [Release notes](https://github.com/MetaMask/providers/releases)
- [Changelog](https://github.com/MetaMask/providers/blob/main/CHANGELOG.md)
- [Commits](MetaMask/providers@v11.1.1...v13.0.0)

---
updated-dependencies:
- dependency-name: "@metamask/providers"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner September 18, 2023 07:37
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 18, 2023
@dependabot dependabot bot mentioned this pull request Sep 18, 2023
Closed
@socket-security
Copy link

socket-security bot commented Sep 18, 2023 •
edited
Loading

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/providers 11.1.1...13.0.0 None +4/-0 564 kB metamaskbot

@socket-security
Copy link

socket-security bot commented Sep 18, 2023 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

@legobeat legobeat mentioned this pull request Sep 20, 2023
Merged
8 tasks
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 20, 2023

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

5 similar comments
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 20, 2023

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 21, 2023

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 21, 2023

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 21, 2023

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 21, 2023

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@jiexi
Copy link

jiexi commented Sep 21, 2023

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 21, 2023

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@Mrtenz
Copy link
Member

Mrtenz commented Sep 26, 2023

@metamaskbot update-pr

@jiexi
Copy link

jiexi commented Sep 27, 2023

@metamaskbot update-policies

@jiexi
Copy link

jiexi commented Sep 27, 2023

Looks like this needs a @metamask/json-rpc-engine bump and json-rpc-middleware-stream bump.

json-rpc-middleware-stream doesn't seem to have 5.0.0 released on npm

@jiexi
Copy link

jiexi commented Sep 28, 2023 •
edited
Loading

also requires matching core bump @metamask/json-rpc-engine. Typescript madness

EDIT: and a core bump of json-rpc-middleware-stream

jiexi@1200775 ~/P/core (jl/bump-json-rpc-engine) [1]> yarn why json-rpc-middleware-stream
├─ @metamask/providers@npm:10.2.1
│  └─ json-rpc-middleware-stream@npm:4.2.2 (via npm:^4.2.1)
│
├─ @metamask/providers@npm:11.1.1
│  └─ json-rpc-middleware-stream@npm:4.2.2 (via npm:^4.2.1)
│
├─ @metamask/providers@npm:13.0.0
│  └─ json-rpc-middleware-stream@npm:4.2.2 (via npm:^4.2.1)
│
├─ @metamask/snaps-controllers@npm:0.38.2-flask.1
│  └─ json-rpc-middleware-stream@npm:4.2.2 (via npm:^4.2.0)
│
└─ @metamask/snaps-controllers@npm:1.0.1
   └─ json-rpc-middleware-stream@npm:4.2.2 (via npm:^4.2.0)

jiexi@1200775 ~/P/core (jl/bump-json-rpc-engine)> yarn why @metamask/providers
├─ @metamask/keyring-api@npm:0.2.5
│  └─ @metamask/providers@npm:13.0.0 (via npm:^13.0.0)
│
├─ @metamask/snaps-execution-environments@npm:0.38.2-flask.1
│  └─ @metamask/providers@npm:11.1.1 (via npm:^11.1.1)
│
├─ @metamask/snaps-execution-environments@npm:1.0.1
│  └─ @metamask/providers@npm:10.2.1 (via npm:^10.2.0)
│
└─ @metamask/snaps-utils@npm:1.0.1
   └─ @metamask/providers@npm:10.2.1 (via npm:^10.2.1)

jiexi@1200775 ~/P/core (jl/bump-json-rpc-engine)> yarn why @metamask/snaps-controllers
├─ @metamask/accounts-controller@workspace:packages/accounts-controller
│  └─ @metamask/snaps-controllers@npm:1.0.1 (via npm:^1.0.1)
│
├─ @metamask/eth-snap-keyring@npm:0.2.2
│  └─ @metamask/snaps-controllers@npm:0.38.2-flask.1 (via npm:^0.38.2-flask.1)
│
└─ @metamask/keyring-api@npm:0.2.5
   └─ @metamask/snaps-controllers@npm:0.38.2-flask.1 (via npm:^0.38.2-flask.1)

json-rpc-middleware-stream needs to be bumped in @metamask/snaps-controllers. what a goose chase

@jiexi
Copy link

jiexi commented Oct 4, 2023

Ahh jeez, this is going to require bumping all of the snaps packages to "@metamask/rpc-errors": "^6.0.0" i think. We need 6.0.0 for alignment on @metamask/utils v8 i think. I'll try 5.1.1 to match the currently used version in snap packages and see if it bugs out.

@jiexi jiexi requested review from Mrtenz and legobeat October 4, 2023 20:10
@jiexi
Copy link

jiexi commented Oct 4, 2023 •
edited
Loading

even on main, i get

Spec Files:	 11 passed, 3 failed, 14 total (100% completed) in 00:02:07

for yarn test:browser

EDIT:

I'm so confused... I didn't change a thing

Spec Files:	 14 passed, 14 total (100% completed) in 00:00:15

@FrederikBolding
Copy link
Member

Closing this in favor of #1818

@jiexi I solved your problems there too!

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 5, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/main/metamask/providers-13.0.0 branch October 5, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mrtenz Mrtenz Awaiting requested review from Mrtenz

@legobeat legobeat Awaiting requested review from legobeat

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jiexi @Mrtenz @FrederikBolding