Bump MetaMask core packages #1818

FrederikBolding · 2023-10-05T09:50:16Z

Rebased and updated version of #1728

Updates and uses @metamask/rpc-errors everywhere
Updates and uses @metamask/json-rpc-engine everywhere
Updates the following packages to latest: @metamask/permission-controller, @metamask/approval-controller, @metamask/providers, @metamask/eth-json-rpc-middleware

Huge thank you to @legobeat for all of the help landing this ❤️

Blocked by #1823

socket-security · 2023-10-05T10:06:49Z

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
json-rpc-middleware-stream	5.0.1	None	`+0`	20.5 kB	gudahtt
@metamask/eth-json-rpc-middleware	11.0.2...12.0.0	None	`+20/-8`	2.06 MB	metamaskbot
@metamask/approval-controller	3.5.2...4.0.0	None	`+2/-2`	280 kB	metamaskbot
@metamask/permission-controller	4.1.2...5.0.0	None	`+15/-15`	1.93 MB	metamaskbot
@metamask/providers	11.1.1...13.0.0	None	`+4/-0`	540 kB	metamaskbot
@metamask/rpc-errors	5.1.1...6.1.0	None	`+0/-0`	85.8 kB	metamaskbot

🚮 Removed packages: @metamask/utils@3.6.0

jiexi · 2023-10-05T16:51:03Z

packages/rpc-methods/src/restricted/getLocale.ts

@@ -68,7 +68,7 @@ export const getLocaleBuilder = Object.freeze({
 */
 export function getImplementation({ getLocale }: GetLocaleMethodHooks) {
  return async function implementation(
-    _args: RestrictedMethodOptions<void>,
+    _args: RestrictedMethodOptions<any>,


This one is a bit difficult, I'm not sure what we we should type this as since we don't use the arguments at all. Any was the best I could come up with, but I don't think it should matter much since the arguments are discarded.

Doesn't work, but RestrictedMethodParameters does.

.yarn/patches/@esbuild-plugins-node-modules-polyfill-npm-0.2.2-f612681798.patch

jiexi · 2023-10-05T17:02:03Z

packages/snaps-controllers/src/services/AbstractExecutionService.ts

@@ -399,7 +397,7 @@ export abstract class AbstractExecutionService<WorkerType>
          handler,
          request,
          target: snapId,
-        },
+        } as Record<string, Json>,


I'm guessing params is causing grief here? if so, could we move the type assertion to params?

It is in fact request that is typed as Record<string, Json> but should be a JsonRpcRequest by the time we get here. I have moved the cast.

packages/snaps-controllers/src/snaps/registry/json.ts

This fixes the Snaps controllers and execution environments tests on #1818.

…>^2.0.0

….0.0

…-engine@^7.1.1

…e@^7.1.1

This fixes the Snaps controllers and execution environments tests on

codecov · 2023-10-11T10:03:16Z

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (552c1cc) 95.98% compared to head (5323126) 95.97%.

Additional details and impacted files

@@                   Coverage Diff                   @@
##           feat/error-handling    #1818      +/-   ##
=======================================================
- Coverage                95.98%   95.97%   -0.02%     
=======================================================
  Files                      241      241              
  Lines                     5586     5592       +6     
  Branches                   877      881       +4     
=======================================================
+ Hits                      5362     5367       +5     
- Misses                     224      225       +1

Files	Coverage Δ
...ackages/rpc-methods/src/permitted/invokeKeyring.ts	`100.00% <100.00%> (ø)`
...kages/rpc-methods/src/permitted/invokeSnapSugar.ts	`100.00% <100.00%> (ø)`
packages/rpc-methods/src/permitted/requestSnaps.ts	`96.22% <100.00%> (ø)`
...thods/src/restricted/caveats/permittedCoinTypes.ts	`100.00% <100.00%> (ø)`
...src/restricted/caveats/permittedDerivationPaths.ts	`96.15% <100.00%> (ø)`
...ages/rpc-methods/src/restricted/caveats/snapIds.ts	`100.00% <100.00%> (ø)`
packages/rpc-methods/src/restricted/dialog.ts	`100.00% <100.00%> (ø)`
...ages/rpc-methods/src/restricted/getBip32Entropy.ts	`100.00% <100.00%> (ø)`
...es/rpc-methods/src/restricted/getBip32PublicKey.ts	`100.00% <100.00%> (ø)`
...ages/rpc-methods/src/restricted/getBip44Entropy.ts	`100.00% <100.00%> (ø)`
... and 24 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@legobeat

Rebased and updated version of #1728 - Updates and uses `@metamask/rpc-errors` everywhere - Updates and uses `@metamask/json-rpc-engine` everywhere - Updates the following packages to latest: `@metamask/permission-controller`, `@metamask/approval-controller`, `@metamask/providers`, `@metamask/eth-json-rpc-middleware` Huge thank you to @legobeat for all of the help landing this ❤️ Blocked by #1823 --------- Co-authored-by: legobt <6wbvkn0j@anonaddy.me> Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>

@legobeat

Rebased and updated version of #1728 - Updates and uses `@metamask/rpc-errors` everywhere - Updates and uses `@metamask/json-rpc-engine` everywhere - Updates the following packages to latest: `@metamask/permission-controller`, `@metamask/approval-controller`, `@metamask/providers`, `@metamask/eth-json-rpc-middleware` Huge thank you to @legobeat for all of the help landing this ❤️ Blocked by #1823 --------- Co-authored-by: legobt <6wbvkn0j@anonaddy.me> Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>

@legobeat

Rebased and updated version of #1728 - Updates and uses `@metamask/rpc-errors` everywhere - Updates and uses `@metamask/json-rpc-engine` everywhere - Updates the following packages to latest: `@metamask/permission-controller`, `@metamask/approval-controller`, `@metamask/providers`, `@metamask/eth-json-rpc-middleware` Huge thank you to @legobeat for all of the help landing this ❤️ Blocked by #1823 --------- Co-authored-by: legobt <6wbvkn0j@anonaddy.me> Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>

This improves error handling by: - Using `@metamask/rpc-errors` instead of `eth-rpc-errors` throughout the entire stack. - Introducing a new `SnapError`, which will not cause the Snap to crash when thrown. - Unwrapping errors where possible. - Also bumps a ton of MetaMask dependencies, see #1818 --------- Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com> Co-authored-by: legobt <6wbvkn0j@anonaddy.me>

This improves error handling by: - Using `@metamask/rpc-errors` instead of `eth-rpc-errors` throughout the entire stack. - Introducing a new `SnapError`, which will not cause the Snap to crash when thrown. - Unwrapping errors where possible. - Also bumps a ton of MetaMask dependencies, see MetaMask/snaps#1818 --------- Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com> Co-authored-by: legobt <6wbvkn0j@anonaddy.me>

FrederikBolding changed the title ~~Bump json-rpc-engine et all~~ Bump MetaMask core packages Oct 5, 2023

jiexi reviewed Oct 5, 2023

View reviewed changes

.yarn/patches/@esbuild-plugins-node-modules-polyfill-npm-0.2.2-f612681798.patch Show resolved Hide resolved

jiexi reviewed Oct 5, 2023

View reviewed changes

packages/snaps-controllers/src/snaps/registry/json.ts Outdated Show resolved Hide resolved

FrederikBolding force-pushed the fb/bump-json-rpc-engine-et-all branch from 9f2ef29 to bb2dcbd Compare October 9, 2023 11:46

Mrtenz mentioned this pull request Oct 10, 2023

Fix snaps-controllers and snaps-execution-environments tests #1835

Merged

Mrtenz changed the base branch from main to feat/error-handling October 10, 2023 13:52

Mrtenz added a commit that referenced this pull request Oct 11, 2023

Fix snaps-controllers and snaps-execution-environments tests (#1835)

8c9ba92

This fixes the Snaps controllers and execution environments tests on #1818.

FrederikBolding mentioned this pull request Oct 11, 2023

Bump @metamask/rpc-errors from 5.1.1 to 6.1.0 #1839

Closed

legobeat added 14 commits October 11, 2023 11:47

deps: @metamask/utils@^7.1.0->^8.1.0

aee71c5

deps: rpc-errors -> @metamask/rpc-errors@^6.0.0

e9b1f67

rpc-methods: @metamask/rpc-errors migration

790c27b

rpc-utils: @metamask/rpc-errors migration

4600d34

lint:fix

5b23c58

snaps-controllers: @metamask/rpc-errors migration

3c439c6

snaps-controllers: @metamask/rpc-errors migration

f269802

lint:fix

b47323a

deps(snaps-controllers,snaps-utils): @metamask/snaps-registry@^1.2.2-…

e970973

…>^2.0.0

deps(snaps-simulator): @metamask/eth-json-rpc-middleware@^11.0.2->^12…

64bcec2

….0.0

deps(snaps-controllers): json-rpc-engine@^6.1.0 -> @metamask/json-rpc…

3d78538

…-engine@^7.1.1

deps: dedupe json-rpc-middleware-stream

dfe9f9d

snaps-controllers: @metamask/rpc-errors update

dcbb6d4

deps: json-rpc-middleware-stream@^4.2.2->^5.0.0

483240a

legobeat and others added 14 commits October 11, 2023 11:47

deps(rpc-methods): json-rpc-engine@^6.1.0 -> @metamask/json-rpc-engin…

fee8195

…e@^7.1.1

wip: @metamask/eth-json-rpc-engine

a795382

wip: deps: @metamask/providers@^11.1.1->^13.0.0

61cdd3f

Bump json-rpc-middleware-stream

4383d9e

Fix typing issues

c57576b

Add missing bumps

6c2b6e3

Fix lint

40712e9

Fix rpc-methods tests

425fc52

Patch polyfill plugin

c9584b2

Port remaining changes after rebase

712a129

Update LavaMoat policies

3b17708

Add missing cause properties

cef9250

update examples checksums

968cacc

Fix snaps-controllers and snaps-execution-environments tests (#1835)

8b0ed91

This fixes the Snaps controllers and execution environments tests on

FrederikBolding force-pushed the fb/bump-json-rpc-engine-et-all branch from 8c9ba92 to 8b0ed91 Compare October 11, 2023 09:51

Fix some type assertions

32a9c3a

FrederikBolding added 2 commits October 11, 2023 12:34

Use latest rpc-errors

69a6ea2

Fix getLocale type

5323126

Mrtenz approved these changes Oct 11, 2023

View reviewed changes

FrederikBolding marked this pull request as ready for review October 11, 2023 10:45

FrederikBolding requested a review from a team as a code owner October 11, 2023 10:45

FrederikBolding merged commit cbf0102 into feat/error-handling Oct 11, 2023
132 of 134 checks passed

FrederikBolding deleted the fb/bump-json-rpc-engine-et-all branch October 11, 2023 11:03

FrederikBolding mentioned this pull request Oct 20, 2023

Improve error handling #1841

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump MetaMask core packages #1818

Bump MetaMask core packages #1818

FrederikBolding commented Oct 5, 2023 •

edited

Loading

socket-security bot commented Oct 5, 2023 •

edited

Loading

jiexi Oct 5, 2023

FrederikBolding Oct 11, 2023

Mrtenz Oct 11, 2023

FrederikBolding Oct 11, 2023

jiexi Oct 5, 2023

FrederikBolding Oct 11, 2023

codecov bot commented Oct 11, 2023 •

edited

Loading

Bump MetaMask core packages #1818

Bump MetaMask core packages #1818

Conversation

FrederikBolding commented Oct 5, 2023 • edited Loading

socket-security bot commented Oct 5, 2023 • edited Loading

jiexi Oct 5, 2023

Choose a reason for hiding this comment

FrederikBolding Oct 11, 2023

Choose a reason for hiding this comment

Mrtenz Oct 11, 2023

Choose a reason for hiding this comment

FrederikBolding Oct 11, 2023

Choose a reason for hiding this comment

jiexi Oct 5, 2023

Choose a reason for hiding this comment

FrederikBolding Oct 11, 2023

Choose a reason for hiding this comment

codecov bot commented Oct 11, 2023 • edited Loading

Codecov Report

FrederikBolding commented Oct 5, 2023 •

edited

Loading

socket-security bot commented Oct 5, 2023 •

edited

Loading

codecov bot commented Oct 11, 2023 •

edited

Loading