-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TypeScript typechecking to snaps-cli #2783
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
f51f19d
[WIP] Add typechecking plugin
ritave dcc4430
Added ts-ignore to globals
ritave 8644cb0
[WIP] Updated tsconfigs to support typechecking
ritave f116b56
Fix type errors in examples
ritave 86592fd
Update lavamoat policy
ritave 13c12c2
Made typescript type-checking in the cli into a config option
ritave 188cfd3
Restore skipped test
ritave 923b2ce
Added test for webpack config in snaps-cli
ritave ab34904
Fix CI failing on snaps-cli due to lack of build files
ritave 42de599
Fix CI test not requiring build step
ritave 00e0cc2
Add explainer comment
ritave 41c4ab7
Fix lint after rebase
ritave f210f23
Fixes after code review
ritave File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,21 +1,8 @@ | ||
{ | ||
"extends": "../../tsconfig.json", | ||
"compilerOptions": { | ||
"baseUrl": "./", | ||
"paths": { | ||
"@metamask/*": ["../../../*/src"] | ||
} | ||
"composite": false, | ||
"baseUrl": "./" | ||
}, | ||
"include": ["src", "snap.config.ts"], | ||
"references": [ | ||
{ | ||
"path": "../../../snaps-sdk" | ||
}, | ||
{ | ||
"path": "../../../snaps-jest" | ||
}, | ||
{ | ||
"path": "../../../snaps-cli" | ||
} | ||
] | ||
"include": ["src", "snap.config.ts"] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,21 +1,8 @@ | ||
{ | ||
"extends": "../../tsconfig.json", | ||
"compilerOptions": { | ||
"baseUrl": "./", | ||
"paths": { | ||
"@metamask/*": ["../../../*/src"] | ||
} | ||
"composite": false, | ||
"baseUrl": "./" | ||
}, | ||
"include": ["src", "snap.config.ts"], | ||
"references": [ | ||
{ | ||
"path": "../../../snaps-sdk" | ||
}, | ||
{ | ||
"path": "../../../snaps-jest" | ||
}, | ||
{ | ||
"path": "../../../snaps-cli" | ||
} | ||
] | ||
"include": ["src", "snap.config.ts"] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,21 +1,8 @@ | ||
{ | ||
"extends": "../../tsconfig.json", | ||
"compilerOptions": { | ||
"baseUrl": "./", | ||
"paths": { | ||
"@metamask/*": ["../../../*/src"] | ||
} | ||
"composite": false, | ||
"baseUrl": "./" | ||
}, | ||
"include": ["src", "snap.config.ts"], | ||
"references": [ | ||
{ | ||
"path": "../../../snaps-sdk" | ||
}, | ||
{ | ||
"path": "../../../snaps-jest" | ||
}, | ||
{ | ||
"path": "../../../snaps-cli" | ||
} | ||
] | ||
"include": ["src", "snap.config.ts"] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,21 +1,8 @@ | ||
{ | ||
"extends": "../../tsconfig.json", | ||
"compilerOptions": { | ||
"baseUrl": "./", | ||
"paths": { | ||
"@metamask/*": ["../../../*/src"] | ||
} | ||
"composite": false, | ||
"baseUrl": "./" | ||
}, | ||
"include": ["src", "snap.config.ts"], | ||
"references": [ | ||
{ | ||
"path": "../../../snaps-sdk" | ||
}, | ||
{ | ||
"path": "../../../snaps-jest" | ||
}, | ||
{ | ||
"path": "../../../snaps-cli" | ||
} | ||
] | ||
"include": ["src", "snap.config.ts"] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,9 @@ const config: SnapConfig = { | |
server: { | ||
port: 8006, | ||
}, | ||
typescript: { | ||
enabled: true, | ||
}, | ||
}; | ||
|
||
export default config; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,21 +1,8 @@ | ||
{ | ||
"extends": "../../tsconfig.json", | ||
"compilerOptions": { | ||
"baseUrl": "./", | ||
"paths": { | ||
"@metamask/*": ["../../../*/src"] | ||
} | ||
"composite": false, | ||
"baseUrl": "./" | ||
}, | ||
"include": ["src", "snap.config.ts"], | ||
"references": [ | ||
{ | ||
"path": "../../../snaps-sdk" | ||
}, | ||
{ | ||
"path": "../../../snaps-jest" | ||
}, | ||
{ | ||
"path": "../../../snaps-cli" | ||
} | ||
] | ||
"include": ["src", "snap.config.ts"] | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this happening now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was always happening, but jest doesn't check types. TSC run over test files and found those issues.