Add platform version field to manifest #2803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2803 +/- ##
==========================================
+ Coverage 94.45% 94.46% +0.01%
==========================================
Files 484 486 +2
Lines 10329 10358 +29
Branches 1574 1579 +5
==========================================
+ Hits 9756 9785 +29
Misses 573 573 ☔ View full report in Codecov by Sentry. |
Mrtenz
force-pushed
the
mrtenz/platform-version-field
branch
from
76650bb
to
8fa16bb
Compare
| return; | ||
| } | ||
|
|
||
| if (semver.gt(manifest.platformVersion, getPlatformVersion())) { |
There was a problem hiding this comment.
Patch versions are probably fine and may not need to reject, WDYT? 🤔
There was a problem hiding this comment.
Technically we can't guarantee that it'll work on a newer patch version, I think, so to be safe, I decided to reject any newer versions.
Mrtenz
force-pushed
the
mrtenz/platform-version-field
branch
from
b5a6500
to
fe59029
Compare
FrederikBolding
previously approved these changes
Oct 22, 2024
FrederikBolding
previously approved these changes
Oct 22, 2024
FrederikBolding
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new field to the manifest,
platformVersion. It is intended to be set to the current version of the Snaps SDK, and if set, is checked by the Snap controller to make sure the current supported version by the Snaps Platform is equal or newer than the specifiedplatformVersion.I've added a feature flag
rejectInvalidPlatformVersionwhich, when enabled, will throw an error upon installation if specified platform version is too new. Otherwise it simply logs a warning in the console.