Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove animated fox from test-snaps page #2859

Merged
merged 4 commits into from
Oct 24, 2024
Merged

Conversation

bowensanders
Copy link
Contributor

This removes the animated fox from the top of the test snaps page.
It replaces it with the much more simple text that says "Test Snaps"

This should eliminate the GL errors occurring in CI testing on the snaps E2E tests.

@bowensanders bowensanders added type-chore Helps the team rather than external people. team-snaps-platform labels Oct 23, 2024
@bowensanders bowensanders self-assigned this Oct 23, 2024
@bowensanders bowensanders requested a review from a team as a code owner October 23, 2024 22:54
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.46%. Comparing base (ec811b7) to head (bca51f0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2859   +/-   ##
=======================================
  Coverage   94.46%   94.46%           
=======================================
  Files         486      486           
  Lines       10360    10360           
  Branches     1582     1582           
=======================================
  Hits         9787     9787           
  Misses        573      573           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

}}
>
<Fox
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

@FrederikBolding
Copy link
Member

@metamaskbot update-pr

@FrederikBolding FrederikBolding merged commit c441eb5 into main Oct 24, 2024
166 checks passed
@FrederikBolding FrederikBolding deleted the bowen/logofix branch October 24, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-snaps-platform type-chore Helps the team rather than external people.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants