Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Faster JSON validation #218

Merged
merged 6 commits into from
Oct 21, 2024
Merged

perf: Faster JSON validation #218

merged 6 commits into from
Oct 21, 2024

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Oct 17, 2024 •
edited
Loading

On my machine this new implementation of UnsafeJsonStruct is significantly faster for the added test case of a large array.

UnsafeJsonStruct (proposed): 1382 ms
UnsafeJsonStruct (current): 38542 ms
Diff: ~-96%

@FrederikBolding FrederikBolding marked this pull request as ready for review October 21, 2024 10:35
@FrederikBolding FrederikBolding requested a review from a team as a code owner October 21, 2024 10:35
Mrtenz
Mrtenz reviewed Oct 21, 2024
View reviewed changes
src/json.ts Show resolved Hide resolved
Mrtenz
Mrtenz previously approved these changes Oct 21, 2024
View reviewed changes
@FrederikBolding FrederikBolding merged commit c12cc9c into main Oct 21, 2024
16 checks passed
@FrederikBolding FrederikBolding deleted the fb/faster-json-validation branch October 21, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mrtenz Mrtenz Mrtenz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FrederikBolding @Mrtenz