One Folder per License Feature #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahiarirani
reviewed
Oct 11, 2024
| @@ -72,7 +72,7 @@ class BeeSwarm extends Common | |||
| public function __construct($params) | |||
| { | |||
| $this->parseParams($params); | |||
| $this->id = 'ethswarm::' . $this->api_url; | |||
| $this->id = 'ethswarm::' .str_replace("https://", "", $this->api_url) . '::'.$this->access_key; | |||
There was a problem hiding this comment.
Actually, the api_url should be always pointing to the same location, thus we can get rid of it to shorten these data store in the db and in fact just link them with the token/access_key.
There was a problem hiding this comment.
Agree! Even if we have a usecase in the future (not sure what it could be right now) that a used needs to point to multiple locations, the token is enought to diferentiate. Also the field id is limited to 64 chars, so I agree on the improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this fix is possible to have multiple swarm folders (one folder per license)