Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

One Folder per License Feature #70

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

One Folder per License Feature #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Storage/BeeSwarm.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ class BeeSwarm extends Common
public function __construct($params)
{
$this->parseParams($params);
$this->id = 'ethswarm::' . $this->api_url;
$this->id = 'ethswarm::' .str_replace("https://", "", $this->api_url) . '::'.$this->access_key;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the api_url should be always pointing to the same location, thus we can get rid of it to shorten these data store in the db and in fact just link them with the token/access_key.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree! Even if we have a usecase in the future (not sure what it could be right now) that a used needs to point to multiple locations, the token is enought to diferentiate. Also the field id is limited to 64 chars, so I agree on the improvement.

$this->storageId = $this->getStorageCache()->getNumericId();

// Load handlers
Expand Down