Setup codebase for Notifications within the plugin. #71
+242
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables notifications for when files are uploaded (aka decentralized) to Swarm.
mahiarirani
reviewed
Oct 11, 2024
| @@ -63,7 +63,7 @@ Experience the future of data storage with 5GB of free, decentralized storage on | |||
|
|
|||
| [Get your free licence here!](https://metaprovide.org/hejbit/start) . | |||
| ]]></description> | |||
| <version>0.5.4</version> | |||
| <version>0.5.0</version> | |||
There was a problem hiding this comment.
Is there any reason to update the version like this for this PR?
There was a problem hiding this comment.
The version should be higher than the lastest that we publish. I think @frozenbanana controls the app versionning on the release process.
| ->addIdentifierAlias('\OC\Files\External_Storage\BeeSwarm') // legacy compat | ||
| ->setStorageClass('\OCA\Files_External_Ethswarm\Storage\BeeSwarm') | ||
| ->setText($l->t('Swarm By Hejbit')) | ||
| ->setText($l->t('Swarm')) |
There was a problem hiding this comment.
I think @JoaoSRaposo wanted to have the HejBit in name in the settings page.
| @@ -425,16 +445,6 @@ public function getMetaData($path) | |||
| return $data; | |||
| } | |||
|
|
|||
| public function getDirectoryContent($path): \Traversable | |||
There was a problem hiding this comment.
I think we should mantain @Thesola10 version on this one
| @@ -104,7 +104,7 @@ private function uploadStream(string $path, string $tmpfile, string $mimetype, i | |||
| */ | |||
| private function downloadStream(string $reference) | |||
| { | |||
| $endpoint = $this->api_url . DIRECTORY_SEPARATOR . 'bzz' . DIRECTORY_SEPARATOR . $reference . DIRECTORY_SEPARATOR; | |||
There was a problem hiding this comment.
This is also related to #63 and not be reverted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables notifications when files are uploaded (aka decentralized) to Swarm.
The message is set in the code in a new class: /lib/Notifications/Notifier.php.
The notification is sent to the user who uploads the content.
Added the Appname 'files_external_ethswarm' as a constant in a new class for application-wide use.