Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the build tool from Webpack to Vite #16

Merged
merged 8 commits into from
Aug 4, 2023

Conversation

LuisdelaVega
Copy link
Collaborator

Changed the build tool from Webpack to Vite.

Description

This migration is an attempt to modernize the Comet starter app by using a build tool like Vite. This will allow us to keep up with modern web development standards while taking advantage of the immediate impact to the development experience and speed that Vite provides.

The React team mainly suggest using what they call "Production-grade React frameworks" when creating a new project, but they have recommended the use of Vite, most noticeably on their page about adding React to an existing project.

Related Issue

N/A

Motivation and Context

N/A

How Has This Been Tested?

Locally. Running npm run dev, npm run test, and npm run e2e.

Screenshots (if appropriate):

N/A

@LuisdelaVega LuisdelaVega added the enhancement New feature or request label Aug 1, 2023
.gitattributes Show resolved Hide resolved
Copy link
Collaborator

@jbouder jbouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, really great work! Was able to verify the app loads super fast and can still do a production build. Also ran all quality checks successfully. Please review the comments provided below.

Also, once all comments are addressed, we will want to get a review from Scott Blair for any feedback.

.gitignore Outdated Show resolved Hide resolved
.prettierrc Outdated Show resolved Hide resolved
.vscode/extensions.json Outdated Show resolved Hide resolved
.vscode/settings.json Outdated Show resolved Hide resolved
.vscode/settings.json Show resolved Hide resolved
src/providers/uswds/uswds.scss Outdated Show resolved Hide resolved
src/styles.scss Outdated Show resolved Hide resolved
src/types.d.ts Outdated Show resolved Hide resolved
src/utils/axios.ts Show resolved Hide resolved
vite.config.ts Outdated Show resolved Hide resolved
@LuisdelaVega
Copy link
Collaborator Author

Just making a note here that I will squash all of these commits before merging.

Copy link
Collaborator

@jbouder jbouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thank you for running this one down.

@jbouder
Copy link
Collaborator

jbouder commented Aug 3, 2023

@sblair-metrostar can you review this change from WebPack to Vite to see if anything jumps out as potential pipeline related concerns?

@sblair-metrostar
Copy link

@sblair-metrostar can you review this change from WebPack to Vite to see if anything jumps out as potential pipeline related concerns?

Unless it creates a dependency on something other than Node 18 and npm/yarn to run the build, I wouldn't expect it to matter much from a pipeline perspective.

@LuisdelaVega LuisdelaVega merged commit b01e2f7 into main Aug 4, 2023
5 checks passed
@LuisdelaVega LuisdelaVega deleted the feature/vite-migration branch August 4, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants